Summary: amfnd: change handling saAmfCSIDependencies to follow the same order for STANDBY as ACTIVE Review request for Trac Ticket(s): 1734 Peer Reviewer(s): praveen Pull request to: praveen Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch supercedes the one I submitted earlier. changeset 639759826f5248be5bbcac340efff0aa4ffa145f Author: Alex Jones <[email protected]> Date: Mon, 02 May 2016 13:57:06 -0400 amfnd: change handling saAmfCSIDependencies to follow the same order for STANDBY as ACTIVE [#1734] When saAmfCSIDependencies is used to order CSIs, STANDBY assignment is done in reverse order from ACTIVE assignment. The code interprets the AMF B.04.01 spec to only order ACTIVE assignment, and all other assignments are done in reverse order. STANDBY assignment should be done based on rank (saAmfCSIDependencies) in the same order as ACTIVE assignment. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/comp.cc | 4 ++-- osaf/services/saf/amf/amfnd/susm.cc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Testing Commands: ----------------- 1) bring up only one controller at first 2) bring up second controller and make sure standby assignments for middleware are done in same order as active 1) test si-swap of middleware (amf-adm si-swap safSi=SC-2N,safApp=OpenSAF) Testing, Expected Results: -------------------------- 1) standby assignments should always be follow same order as active Conditions of Submission: ------------------------- Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
