Hi Mahesh,

It was tested.
Could you please help to push the patch? Thanks.

Best regards,
Nhat Pham

-----Original Message-----
From: A V Mahesh [mailto:[email protected]]
Sent: Wednesday, May 18, 2016 12:15 PM
To: Nhat Pham <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 1 of 1] cpnd: To indicate clm_updated_sel_obj in
cpnd_clm_init_thread [#1830]

Hi Nhat Pham,

I hope you have tested the testcase of #1821 case with this patch
(saClmDispatch() fail case).

-AVM

On 5/18/2016 10:20 AM, Nhat Pham wrote:
>   osaf/services/saf/cpsv/cpnd/cpnd_init.c |  8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)
>
>
> Problem:
> --------
> The message "ncs_sel_obj_ind: write failed - Bad file descriptor"
sometimes happens when the node reboot.
> This is because indicating clm_updated_sel_obj is executed in
> cpnd_clm_init() at start up. In this case the clm_updated_sel_obj is not
created yet.
>
> Solution:
> ---------
> To execute indicating clm_updated_sel_obj in the
> cpnd_clm_init_thread()
>
> diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_init.c
> b/osaf/services/saf/cpsv/cpnd/cpnd_init.c
> --- a/osaf/services/saf/cpsv/cpnd/cpnd_init.c
> +++ b/osaf/services/saf/cpsv/cpnd/cpnd_init.c
> @@ -659,9 +659,6 @@ static SaAisErrorT cpnd_clm_init(void)
>               goto cpnd_clm_fail;
>       }
>
> -     /* Notify main process to update clm select object */
> -     ncs_sel_obj_ind(&cb->clm_updated_sel_obj);
> -
>       TRACE_LEAVE();
>       return rc;
>
> @@ -686,6 +683,8 @@ static SaAisErrorT cpnd_clm_init(void)
>
****************************************************************************
*/
>   static void* cpnd_clm_init_thread(void* arg)
>   {
> +     CPND_CB *cb = m_CPND_TAKE_CPND_CB;
> +
>       TRACE_ENTER();
>
>       SaAisErrorT rc = cpnd_clm_init();
> @@ -693,6 +692,9 @@ static void* cpnd_clm_init_thread(void*
>               exit(EXIT_FAILURE);
>       }
>
> +     /* Notify main process to update clm select object */
> +     ncs_sel_obj_ind(&cb->clm_updated_sel_obj);
> +
>       TRACE_LEAVE();
>       return NULL;
>   }



------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to