Summary: amfnd: fix COMP-FO recovery when cleanup time is more than
sufailoverprob[#1839]
Review request for Trac Ticket(s): #1839
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 2dd6b31dbce96c82eba26192c0a13f5c5f0d7b1d
Author: praveen.malv...@oracle.com
Date: Thu, 19 May 2016 15:33:26 +0530
amfnd: fix COMP-FO recovery when cleanup time is more than
sufailoverprob[#1839]
In the reported problem, fault of comp leads to comp-failover
escalation.But
failover did not happen.
As a part of compt-failover, amfnd launched cleanup if component. Before
clean up gets completed, su-failover time expires and AMND resets
escalation
parameters. In this way AMFND loses that the context of cleanup is comp-
failver recovery. When comp gets cleaned up successfully, AMFND (not
ware of
context) does inform AMFD for failover of assignments.
Patch fixes problem by remembering the comp or su failover context
using a
separate flag and not relying on escalation params.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/clc.cc | 2 +-
osaf/services/saf/amf/amfnd/err.cc | 11 ++++++++++-
osaf/services/saf/amf/amfnd/susm.cc | 10 +++++-----
3 files changed, 16 insertions(+), 7 deletions(-)
Testing Commands:
-----------------
Tested only reported case.
More testing to be done.
Testing, Expected Results:
--------------------------
Failover observed and su was repaired.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
