Hi,
Two things:
1. This problem is because of #1842. Earlier Amfd use to first do cold
sync and then use to notify nid, after that Amfnd use to come up hence the
following logic use to work to return TRY_AGAIN:
if (si->list_of_sisu->si_next == nullptr) {
LOG_ER("%s SWAP failed - only one assignment", si->name.value);
rc = SA_AIS_ERR_TRY_AGAIN;
goto done;
}
Since, #1842 has broken the previous fix of synchronising startup sequence,
hence Amfnd is coming up before Amfd and getting SUSI assignment and the above
logic fails and hence swap is accepted and the problem of #1841 comes.
2. The fix may work fine. But normal logic in Amf needs correction. In
general, Amfd should be in sync if Standby Amfd is not there or there but
synced. When Amfd is syncing only then we mark OUT_OF_SYNC. But with the fix,
the logic will be just opposite and it is better if we can correct the logic at
other places, i.e. mark Amfd out of sync if Amfd is not there or it is syncing.
Thanks
-Nagu
> -----Original Message-----
> From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
> Sent: 20 May 2016 11:43
> To: Praveen Malviya; Nagendra Kumar; gary....@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: Avoid SI swap if cold sync has not been
> requested [#1841]
>
> osaf/services/saf/amf/amfd/mds.cc | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/mds.cc
> b/osaf/services/saf/amf/amfd/mds.cc
> --- a/osaf/services/saf/amf/amfd/mds.cc
> +++ b/osaf/services/saf/amf/amfd/mds.cc
> @@ -413,6 +413,7 @@ static uint32_t avd_mds_svc_evt(MDS_CALL
> if ((evt_info->i_node_id != cb->node_id_avd) &&
> (m_MDS_DEST_IS_AN_ADEST(evt_info->i_dest))) {
> cb->node_id_avd_other = evt_info-
> >i_node_id;
> cb->other_avd_adest = evt_info->i_dest;
> + cb->stby_sync_state =
> AVD_STBY_OUT_OF_SYNC;
> }
> break;
>
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
