Hi Vu,
With this patch i am seeing considerble erros for `/usr/bin/logtest`
Note : I am usng 5.0 GA release with changeset:7606 with log
service tickets #1789, #1805 , #1807
Am I missing any other critical patch on top of changeset:7606 ?
Test Result:
Total: 205
Passed: 194
Failed: 11
================================================================================================================================
Log file size (0) is less than 65535
39 FAILED Modify: saLogStreamFixedLogRecordSize == 0, write a
record = 65535 bytes, OK (expected UNKNOWN, got SA_AIS_NOT_VALID);
Log file size (0) is less than 65535
40 FAILED Modify: saLogStreamFixedLogRecordSize == 65535, Write a
record = 65535 bytes with special characters, OK (expected UNKNOWN, got
SA_AIS_NOT_VALID);
41 PASSED Write 20 log records to System/Notification stream.
MANUALLY verify millisecond increased continuously;
================================================================================================================================
================================================================================================================================
57 PASSED saflogtest, writing to saLogApplication1, severity
filtering check;
58 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogstreamLogFileFormat, timezone token (@Nz);
59 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogstreamLogFileFormat, millisecond token (@Nk);
60 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogstreamLogFileFormat, timezone token (@Cz);
61 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogstreamLogFileFormat, millisecond token (@Ck);
62 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogstreamLogFileFormat, timezone & millisecond token
(@Cz @Ck);
63 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogStreamLogFileFormat, node name token (@Cq);
64 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) CCB
Object Modify, saLogStreamLogFileFormat, network name token (@Cp);
65 FAILED (expected EXIT_SUCCESS, got UNKNOWN (123)) Application
stream with default log file format;
Suite 5: LOG OI tests, Service configuration object
1 PASSED CCB Object Modify, root directory. Path does not exist.
Not allowed;
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
OI reports: IMM: Validation abort: Completed validation fails
(ERR_BAD_OPERATION)
OI reports: pathName: /var/log/opensaf/saflog/xxtest is NOT accepted
'immcfg -a logRootDirectory=/var/log/opensaf/saflog/xxtest
logConfig=1,safApp=safLogService' Fail rc=1
2 FAILED (expected EXIT_SUCCESS, got EXIT_FAILURE (1)) CCB
Object Modify, root directory. Path exist. OK;
================================================================================================================================
On 5/26/2016 12:53 PM, Lennart Lund wrote:
> Ack
>
> Thanks
> Lennart
>
>> -----Original Message-----
>> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>> Sent: den 26 maj 2016 04:18
>> To: mathi.naic...@oracle.com; Lennart Lund <lennart.l...@ericsson.com>
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: [PATCH 1 of 1] log: fix log file sizes grow rapidly and cannot open
>> [#1851]
>>
>> osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>>
>> Not convert `offset` data to `off_t` when passing to `lseek`,
>> causing the `offset` value is an big big number.
>>
>> This patch does convert `offset` value to `off_t` type.
>>
>> diff --git a/osaf/services/saf/logsv/lgs/lgs_filehdl.cc
>> b/osaf/services/saf/logsv/lgs/lgs_filehdl.cc
>> --- a/osaf/services/saf/logsv/lgs/lgs_filehdl.cc
>> +++ b/osaf/services/saf/logsv/lgs/lgs_filehdl.cc
>> @@ -263,7 +263,6 @@ int write_log_record_hdl(void *indata, v
>> if (bytes_written < params_in->record_size)
>> goto retry;
>> }
>> -
>> osaf_mutex_lock_ordie(&lgs_ftcom_mutex); /* LOCK after
>> critical section */
>>
>> /* If the thread was hanging and has timed out and the log
>> record was
>> @@ -271,8 +270,8 @@ int write_log_record_hdl(void *indata, v
>> * returned SA_AIS_TRY_AGAIN).
>> */
>> if (*timeout_f == true) {
>> - TRACE("Timeout, removing last log record");
>> - file_length = lseek(params_in->fd, -
>> bytes_written, SEEK_END);
>> + LOG_NO("Timeout, removing last log record");
>> + file_length = lseek(params_in->fd, -
>> ((off_t)bytes_written), SEEK_END);
>> if (file_length != -1) {
>> do {
>> rc =
>> ftruncate(params_in->fd, file_length);
> ------------------------------------------------------------------------------
> Mobile security can be enabling, not merely restricting. Employees who
> bring their own devices (BYOD) to work are irked by the imposition of MDM
> restrictions. Mobile Device Manager Plus allows you to control only the
> apps on BYO-devices by containerizing them, leaving personal data untouched!
> https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
