Hi Nhat Pham, Some how this # 1667 review was not in devel list mails
I am finding an IMM ticket with `[devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667]` Can you please resend -AVM On 6/3/2016 5:50 AM, Nhat Pham wrote: > Hi Mahesh, > > Could you please help to review this? Thanks. > > Best regards, > Nhat Pham > > -----Original Message----- > From: Nhat Pham [mailto:[email protected]] > Sent: Wednesday, April 13, 2016 4:27 PM > To: [email protected]; [email protected] > Cc: [email protected] > Subject: [devel] [PATCH 0 of 2] Review Request for cpsv: cpnd restart with > coredump when creating a section with id size greater than 30 [#1667] > > Summary: cpsv: cpnd restart with coredump when creating a section with id > size greater than 30 [#1667] Review request for Trac Ticket(s): #1667 Peer > Reviewer(s): [email protected]; [email protected] Pull > request to: [email protected] Affected branch(es): default, 5.0, and > 4.7 Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 0e0fc6a3c00145a9beaa8558c7a6251deb9adf99 > Author: Nhat Pham <[email protected]> > Date: Thu, 07 Apr 2016 15:45:25 +0700 > > ckpt: To add a new test case to verify creating section with id > lenght longer than MAX_SIZE(30) > > changeset 7cc939f0e111e649ee7a06b5207069421a0335d7 > Author: Nhat Pham <[email protected]> > Date: Thu, 07 Apr 2016 15:45:50 +0700 > > cpnd: To reject creating section which has id length longer than > MAX_SIZE(30) > > > Complete diffstat: > ------------------ > osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 11 +++++++++++ > tests/cpsv/test_cpa.c | 35 > ++++++++++++++++++++++++++++++++++- > tests/cpsv/test_cpa_util.c | 2 ++ > tests/cpsv/test_cpsv.h | 1 + > tests/cpsv/test_cpsv_conf.h | 2 ++ > 5 files changed, 50 insertions(+), 1 deletions(-) > > > Testing Commands: > ----------------- > ckpttest 11 16 > > Testing, Expected Results: > -------------------------- > The test case passes. > > Conditions of Submission: > ------------------------- > - > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ---------------------------------------------------------------------------- > -- > Find and fix application performance issues faster with Applications Manager > Applications Manager provides deep performance insights into multiple tiers > of your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
