Ack code review only. Thanks, Praveen
On 09-Jun-16 5:11 AM, minh chau wrote: > Hi Praveen, > > saAmfSUHostedByNode should be cold synced after headless. The > avd_process_state_info_queue() is called before active amfd creates > Opensaf-2N assignment for SCs. The standby assignment for Opensaf-2N on > standby controller includes RDE csi which then set node role as standby, > thus the main thread in standby amfd wakes up and request cold sync later. > > Thanks, > Minh > > On 08/06/16 16:18, praveen malviya wrote: >> Hi Minh, >> >> Please find one query below. >> >> Thanks, >> Praveen >> >> On 07-Jun-16 6:17 AM, Minh Hon Chau wrote: >>> osaf/services/saf/amf/amfd/siass.cc | 4 +++- >>> 1 files changed, 3 insertions(+), 1 deletions(-) >>> >>> >>> After being headless, the RTA saAmfSUHostedByNode of SU has not been >>> updated. >>> That will cause the messaging to SU in wrong node. >>> >>> While performing recovery from headless, the saAmfSUHostedByNode of >>> SU can be >>> updated by node that susi_state_info msg comes from. >>> >>> diff --git a/osaf/services/saf/amf/amfd/siass.cc >>> b/osaf/services/saf/amf/amfd/siass.cc >>> --- a/osaf/services/saf/amf/amfd/siass.cc >>> +++ b/osaf/services/saf/amf/amfd/siass.cc >>> @@ -888,7 +888,9 @@ SaAisErrorT avd_susi_recreate(AVSV_N2D_N >>> susi->su->inc_curr_act_si(); >>> susi->si->inc_curr_act_ass(); >>> } >>> - >>> + su->saAmfSUHostedByNode = node->name; >>> + avd_saImmOiRtObjectUpdate(&su->name, >>> "saAmfSUHostedByNode", >>> + SA_IMM_ATTR_SANAMET, &su->saAmfSUHostedByNode); >> Is it not required to checkpoint SU_CONFIG state here as active AMFD >> is updating SU states with the information from Node directors? Only >> possibility of standby getting updated is cold sync. Will the cold >> sync always happen after all the node directors have sent the >> sisu_recreate messages? >> >> >>> m_AVSV_SEND_CKPT_UPDT_ASYNC_ADD(avd_cb, susi, AVSV_CKPT_AVD_SI_ASS); >>> } >>> >>> >> > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
