ACK , Tested .
-AVM
On 6/9/2016 11:24 AM, Hung Nguyen wrote:
> Hi Mahesh,
>
> The script compares ETH_NAME (which is comma delimited) with output from
> "tipc-config -b" (which is LF delimited).
> That only works when using single bearer.
> The script will fail in case of multiple bearers.
>
>
> configured_bearer=`tipc-config -b | grep -v Bearer | cut -d: -f2` <== LF
> delimited
> opensaf_bearer=$ETH_NAME <== comma
> delimited
> if [ $configured_bearer != $opensaf_bearer ] <== will
> not work in case of multiple bearers
>
>
> I agree that the commit message is misleading, will change them when pushing
> if the patch is ack'ed.
>
>
> BR,
> Hung Nguyen - DEK Technologies
>
> --------------------------------------------------------------------------------
> From: Mahesh vallamahesh.va...@oracle.com
> Sent: Thursday, June 09, 2016 12:24PM
> To: Opensaf-devel
> opensaf-devel@lists.sourceforge.net
> Cc:
>
> Subject: Re: [devel] [PATCH 1 of 1] nid: Add support for multiple tipc
> bearers to configure_tipc [#1862]
>
>
> Hi Hung Nguyen,
>
>>> Add support for multiple tipc bearers to configure_tipc.
> This support already exist and we have been configuring & using
> multiple tipc bearers, it works with
>
> ======================================================================
> /etc/opensaf/nid.conf
>
> # This is valid when above MDS_TRANSPORT is set to TIPC and
> OPENSAF_MANAGE_TIPC is set to "yes" ,
> # values supported is the network interface name, e.g. eth3
>
> TIPC_ETH_IF=eth0,eth1
> ======================================================================
>
> I did see any change except `sort` list , we need to verify
> implication of adding sort for the following configuration , we will provide
> our observation , please hold.
>
> NODE-1
> ===================================================================
> eth0 192.168.56.101
>
> eth1 10.176.177.138
>
> with /etc/opensaf/nid.conf - TIPC_ETH_IF=eth0,eth1
> ===================================================================
>
>
> NODE-2
> ===================================================================
> eth0 10.176.177.139
>
> eth1 192.168.56.102
>
> with /etc/opensaf/nid.conf - TIPC_ETH_IF=eth0,eth1
> ===================================================================
>
> -AVM
>
> On 6/9/2016 9:49 AM, Hung Nguyen wrote:
>> osaf/services/infrastructure/nid/scripts/configure_tipc.in | 12
>> +++---------
>> 1 files changed, 3 insertions(+), 9 deletions(-)
>>
>>
>> Add support for multiple tipc bearers to configure_tipc.
>> Also remove the check for CORE_ID.
>>
>> diff --git a/osaf/services/infrastructure/nid/scripts/configure_tipc.in
>> b/osaf/services/infrastructure/nid/scripts/configure_tipc.in
>> --- a/osaf/services/infrastructure/nid/scripts/configure_tipc.in
>> +++ b/osaf/services/infrastructure/nid/scripts/configure_tipc.in
>> @@ -276,16 +276,10 @@ else
>> logger -t opensaf -s "TIPC network ID not configured to OpenSAF
>> requirements, exiting..."
>> exit 1
>> fi
>> - configured_net_id=`tipc-config -netid | cut -d: -f2`
>> - opensaf_net_id=$CORE_ID
>> - if [ $configured_net_id != $opensaf_net_id ]; then
>> - logger -t opensaf -s "TIPC network ID not configured to OpenSAF
>> requirements, exiting..."
>> - exit 1
>> - fi
>>
>> - configured_bearer=`tipc-config -b | grep -v Bearer | cut -d: -f2`
>> - opensaf_bearer=$ETH_NAME
>> - if [ $configured_bearer != $opensaf_bearer ]; then
>> + configured_bearers=$(${tipc_config} -b | grep -v Bearer | cut -d: -f2 |
>> sort)
>> + opensaf_bearers=$(echo "$ETH_NAME" | tr "," "\n" | sort)
>> + if [ "$configured_bearers" != "$opensaf_bearers" ]; then
>> logger -t opensaf -s "TIPC bearer not configured to OpenSAF
>> requirements, exiting..."
>> exit 1
>> fi
>>
>> ------------------------------------------------------------------------------
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning reports.https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
>> _______________________________________________
>> Opensaf-devel mailing list
>> Opensaf-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports.https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
