Summary: rde: Fix cppcheck warnings [#1870]
Review request for Trac Ticket(s): 1870
Peer Reviewer(s): Ramesh
Pull request to:
Affected branch(es): default(5.1)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset f2309bc01df86422049e5121a69f45aa766b4718
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 09 Jun 2016 11:13:47 +0200
rde: Fix cppcheck warnings [#1870]
The following warnings, reported by cppcheck version 1.74, have been
fixed:
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:300]: (style) C-style
pointer casting [osaf/libs/agents/infrastructure/rda/rda_papi.cc:347] ->
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:356]: (style) Variable
'rc'
is reassigned a value before the old one has been used.
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:410] ->
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:421]: (style) Variable
'rc'
is reassigned a value before the old one has been used.
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:585] ->
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:593]: (style) Variable
'rc'
is reassigned a value before the old one has been used.
[osaf/libs/agents/infrastructure/rda/rda_papi.cc:516]: (style) A
pointer can
not be negative so it is either pointless or an error to check if it is.
[osaf/services/infrastructure/rde/include/role.h:34]: (style) Class
'Role'
has a constructor with 1 argument that is not explicit.
[osaf/services/infrastructure/rde/rde_mds.cc:240] ->
[osaf/services/infrastructure/rde/rde_mds.cc:251]: (style) Variable
'rc' is
reassigned a value before the old one has been used.
[osaf/services/infrastructure/rde/rde_rda.cc:374] ->
[osaf/services/infrastructure/rde/rde_rda.cc:381]: (style) Variable
'sockfd'
is reassigned a value before the old one has been used.
[osaf/tools/rde/rde_get_role.c:38] ->
[osaf/tools/rde/rde_get_role.c:40]:
(style) Variable 'ret_val' is reassigned a value before the old one has
been
used. [osaf/services/infrastructure/rde/rde_rda.cc:473]: (style) The
function 'rde_rda_close' is never used.
[osaf/services/infrastructure/rde/rde_rda.cc:417]: (style) The function
'rde_rda_sock_name' is never used.
Complete diffstat:
------------------
osaf/libs/agents/infrastructure/rda/rda_papi.cc | 13 +++++--------
osaf/services/infrastructure/rde/include/rde_rda.h | 2 --
osaf/services/infrastructure/rde/include/role.h | 2 +-
osaf/services/infrastructure/rde/rde_mds.cc | 3 +--
osaf/services/infrastructure/rde/rde_rda.cc | 58
+---------------------------------------------------------
osaf/tools/rde/rde_get_role.c | 3 +--
6 files changed, 9 insertions(+), 72 deletions(-)
Testing Commands:
-----------------
make cppcheck
Testing, Expected Results:
--------------------------
cppcheck version 1.74 should not report any warnings in the RDE service
Conditions of Submission:
-------------------------
Ack from reviewer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
