Hi Praveen

ack with minor comment below:

> On 9 Jun 2016, at 8:45 PM, [email protected] wrote:
> 
> osaf/services/saf/amf/amfd/ckpt_dec.cc |  6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
> 
> 
> Standby AMFD may get MBCSV checkpoint update for NG admin state after 
> deletion of
> nodegroup through CCB.
> The only possibility for this is:
> -A user performs admin operation on NG and deletes it instantaneously.
> If mvcsv checkpoint comes after CCB operations then standby amfd will assert 
> in
> dec_ng_admin_state().
> 
> As a fix, standby AMFD must update only ckpt update count and avoid assert.
> 
> diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc 
> b/osaf/services/saf/amf/amfd/ckpt_dec.cc
> --- a/osaf/services/saf/amf/amfd/ckpt_dec.cc
> +++ b/osaf/services/saf/amf/amfd/ckpt_dec.cc
> @@ -2838,7 +2838,11 @@ static uint32_t dec_ng_admin_state(AVD_C
>       TRACE_ENTER();
>       osaf_decode_sanamet(&dec->i_uba, &name);
>       AVD_AMF_NG *ng = nodegroup_db->find(Amf::to_string(&name));
> -     osafassert(ng != nullptr);
> +     if (ng == nullptr) {
> +             LOG_WA("Could not find %s in nodegroup_db", name.value);
> +             cb->async_updt_cnt.ng_updt++;

[GL] please add TRACE_LEAVE

> +             return NCSCC_RC_SUCCESS;
> +     }
>       osaf_decode_uint32(&dec->i_uba, (uint32_t*)&ng->saAmfNGAdminState);
>       cb->async_updt_cnt.ng_updt++;
> 


------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to