Hi Hung, Ignore it.
Thanks, Zoran From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Tuesday, June 14, 2016 12:25 PM To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] immtools: Fix memory leak in init_param() [#1876] Hi Zoran, The 'param' is stored in 'params' (in main() function). So they are marked as 'still reachable', not memory leak. I think we can ignore them. BR, Hung Nguyen - DEK Technologies -------------------------------------------------------------------------------- From: Zoran Milinkovic zoran.milinko...@ericsson.com<mailto:zoran.milinko...@ericsson.com> Sent: Tuesday, June 14, 2016 4:17PM To: Hung Nguyen, Neelakanta Reddy hung.d.ngu...@dektech.com.au<mailto:hung.d.ngu...@dektech.com.au>, reddy.neelaka...@oracle.com<mailto:reddy.neelaka...@oracle.com> Cc: Opensaf-devel opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: [PATCH 1 of 1] immtools: Fix memory leak in init_param() [#1876] Hi Hung, param->paramName alsp need to be freed. Reviewed the patch. Ack from me. Thanks, Zoran -----Original Message----- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Tuesday, June 14, 2016 10:37 AM To: Zoran Milinkovic <zoran.milinko...@ericsson.com><mailto:zoran.milinko...@ericsson.com>; reddy.neelaka...@oracle.com<mailto:reddy.neelaka...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: [PATCH 1 of 1] immtools: Fix memory leak in init_param() [#1876] osaf/tools/safimm/immadm/imm_admin.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) Fix memory leak in init_param(). diff --git a/osaf/tools/safimm/immadm/imm_admin.c b/osaf/tools/safimm/immadm/imm_admin.c --- a/osaf/tools/safimm/immadm/imm_admin.c +++ b/osaf/tools/safimm/immadm/imm_admin.c @@ -159,10 +159,13 @@ static int init_param(SaImmAdminOperatio param->paramBuffer = immutil_new_attrValue(param->paramType, attrValue); - if (param->paramBuffer == NULL) - return -1; + if (param->paramBuffer == NULL) { + res = -1; + goto done; + } done: + free(tmp); return res; } ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
