Summary: imm: Fix cppcheck errors (enhancement) [#1881]
Review request for Trac Ticket(s): 1881
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.1
Development branch: 5.1
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset d1e9bc607ebec00f0720f028d6df014ab2c55056
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 15 Jun 2016 11:39:56 +0700
imm: Remove conditional statements using 'mDir' and 'mFile' [#1881]
'mDir' and 'mFile' are checked during the initialization of IMMND. If
they
are NULL, IMMND will fail to start. We can assume that they are not
NULL if
IMMND starts successfully.
changeset 1a39fdcace5ea904215ce172da75eccc3d1191ec
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Thu, 16 Jun 2016 13:39:19 +0700
imm: Assert 'rspList' before generating search bundle response [#1881]
Assert 'rspList' before generating search bundle response.
changeset 8ac3b0c9e790edca5bad6ed018fbad255f091e12
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 15 Jun 2016 18:48:06 +0700
imm: Remove ccbsToGc in ::cleanTheBasement [#1881]
While iterating through sCcbVector, if find any ccb terminated more
than 5
minutes, collect the garbage immediately. We don't need to push the ccb
to
ccbsToGc and delay the garbage collection.
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 20 ++++++--------------
osaf/services/saf/immsv/immnd/immnd_evt.c | 1 +
osaf/services/saf/immsv/immnd/immnd_proc.c | 21 ++++++++-------------
3 files changed, 15 insertions(+), 27 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://sdm.link/zohomanageengine
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
