Ack with the following comment to take care.
Please clean in PLM too..
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
/osaf/services/saf/plmsv/plms/plms_main.c: params.info_size = 0;/
Thanks,
Ramesh.
On 6/15/2016 8:21 PM, Anders Widell wrote:
> Summary: base: Fix cppcheck warnings [#1879]
> Review request for Trac Ticket(s): 1879
> Peer Reviewer(s): Ramesh
> Pull request to:
> Affected branch(es): default(5.1)
> Development branch: default
>
> --------------------------------
> Impacted area Impact y/n
> --------------------------------
> Docs n
> Build system n
> RPM/packaging n
> Configuration files n
> Startup scripts n
> SAF services n
> OpenSAF services n
> Core libraries y
> Samples n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
>
> changeset 5231c1f8ebff0ffb4c519f4d085241a3296de202
> Author: Anders Widell <[email protected]>
> Date: Wed, 15 Jun 2016 16:35:19 +0200
>
> build: Update cppcheck target options [#1879]
>
> * Use inline suppressions instead of listing them on the command line
> * Enable the gnu and posix libraries
> * Remove unnecessary defines
>
> changeset 12731334579982e4be65f21d52a260bbe8c9487d
> Author: Anders Widell <[email protected]>
> Date: Wed, 15 Jun 2016 16:35:25 +0200
>
> amf: Remove unused info_size patricia tree parameter [#1879]
>
> changeset 239129245d4a1ec851db40e1c08c81918cde9aad
> Author: Anders Widell <[email protected]>
> Date: Wed, 15 Jun 2016 16:35:30 +0200
>
> lck: Remove unused info_size patricia tree parameter [#1879]
>
> changeset 4c6b2b8d1074bc62afa185a949e474ccd3d235b3
> Author: Anders Widell <[email protected]>
> Date: Wed, 15 Jun 2016 16:35:34 +0200
>
> msg: Remove unused info_size patricia tree parameter [#1879]
>
> changeset 7766ef7bf0a97dfaf0b206d36967aeaddb140b8f
> Author: Anders Widell <[email protected]>
> Date: Wed, 15 Jun 2016 16:44:54 +0200
>
> base: Fix cppcheck warnings [#1879]
>
> The following warnings, reported by cppcheck version 1.74, have been
> fixed:
>
> [osaf/libs/core/common/daemon.c:212]: (style) The scope of the variable
> 'plibc_prctl' can be reduced. [osaf/libs/core/common/daemon.c:214]:
> (style)
> The scope of the variable 'pid' can be reduced.
> [osaf/libs/core/common/daemon.c:214]: (style) The scope of the variable
> 'sid' can be reduced. [osaf/libs/core/common/daemon.c:505]: (style) The
> scope of the variable 'bt_filename_size' can be reduced.
> [osaf/libs/core/common/daemon.c:507]: (style) The scope of the variable
> 'time_string' can be reduced. [osaf/libs/core/common/daemon.c:510]:
> (style)
> The scope of the variable 'i' can be reduced.
> [osaf/libs/core/common/daemon.c:340]: (portability) Non reentrant
> function
> 'getpwnam' called. For threadsafe applications it is recommended to use
> the
> reentrant replacement function 'getpwnam_r'.
> [osaf/libs/core/common/daemon.c:533]: (portability) Non reentrant
> function
> 'localtime' called. For threadsafe applications it is recommended to
> use the
> reentrant replacement function 'localtime_r'.
> [osaf/libs/core/common/daemon.c:256]: (error) Uninitialized variable:
> param
> [osaf/libs/core/common/daemon.c:528]: (error) Uninitialized variable:
> time_string [osaf/libs/core/common/daemon.c:539]: (error) Uninitialized
> variable: time_string [osaf/libs/core/common/ncs_main_pub.c:178] ->
> [osaf/libs/core/common/ncs_main_pub.c:180]: (style) Variable 'rc' is
> reassigned a value before the old one has been used.
> [osaf/libs/core/common/ncs_main_pub.c:315] ->
> [osaf/libs/core/common/ncs_main_pub.c:317]: (style) Variable 'rc' is
> reassigned a value before the old one has been used.
> [osaf/libs/core/common/ncs_main_pub.c:714]: (style) The scope of the
> variable 'p_field' can be reduced.
> [osaf/libs/core/common/ncs_main_pub.c:794]: (style) The scope of the
> variable 'tmp' can be reduced.
> [osaf/libs/core/common/ncs_main_pub.c:129]:
> (style) struct member 'ncs_main_pub_cb::lock_create' is never used.
> [osaf/libs/core/common/ncs_main_pub.c:693]: (style) Variable 'res' is
> assigned a value that is never used.
> [osaf/libs/core/common/nid_start_util.c:54]: (warning) fscanf() without
> field width limits can crash with huge input data.
> [osaf/libs/core/common/osaf_extended_name.c:183]: (error) Memory is
> allocated but not initialized: pointer
> [osaf/libs/core/common/osaf_poll.c:117]: (error) Uninitialized variable:
> elapsed_time [osaf/libs/core/common/osaf_poll.c:118]: (error)
> Uninitialized
> variable: elapsed_time [osaf/libs/core/common/osaf_poll.c:120]: (error)
> Uninitialized variable: elapsed_time
> [osaf/libs/core/common/osaf_poll.c:134]: (error) Uninitialized
> variable: set
> [osaf/libs/core/common/osaf_poll.c:135]: (error) Uninitialized
> variable: set
> [osaf/libs/core/common/osaf_secutil.c:243]: (portability) Non reentrant
> function 'getpwuid' called. For threadsafe applications it is
> recommended to
> use the reentrant replacement function 'getpwuid_r'.
> [osaf/libs/core/common/osaf_secutil.c:353]: (portability) Non reentrant
> function 'getpwuid' called. For threadsafe applications it is
> recommended to
> use the reentrant replacement function 'getpwuid_r'.
> [osaf/libs/core/common/osaf_secutil.c:370]: (portability) Non reentrant
> function 'getgrent' called. For threadsafe applications it is
> recommended to
> use the reentrant replacement function 'getgrent_r'.
> [osaf/libs/core/common/osaf_secutil.c:379]: (portability) Non reentrant
> function 'getgrent' called. For threadsafe applications it is
> recommended to
> use the reentrant replacement function 'getgrent_r'.
> [osaf/libs/core/common/osaf_secutil.c:399]: (portability) Non reentrant
> function 'getgrent' called. For threadsafe applications it is
> recommended to
> use the reentrant replacement function 'getgrent_r'.
> [osaf/libs/core/common/osaf_secutil.c:82]: (error) Uninitialized
> variable:
> fds [osaf/libs/core/common/osaf_secutil.c:83]: (error) Uninitialized
> variable: fds [osaf/libs/core/common/osaf_secutil.c:136]: (error)
> Uninitialized variable: unaddr
> [osaf/libs/core/common/osaf_secutil.c:170]:
> (error) Uninitialized variable: fds
> [osaf/libs/core/common/osaf_secutil.c:171]: (error) Uninitialized
> variable:
> fds [osaf/libs/core/common/osaf_secutil.c:203]: (error) Memory is
> allocated
> but not initialized: fd [osaf/libs/core/common/osaf_secutil.c:279]:
> (error)
> Uninitialized variable: remote
> [osaf/libs/core/common/osaf_secutil.c:295]:
> (error) Uninitialized variable: fds
> [osaf/libs/core/common/osaf_secutil.c:296]: (error) Uninitialized
> variable:
> fds [osaf/libs/core/common/osaf_timerfd.c:184]: (error) Uninitialized
> variable: event [osaf/libs/core/common/osaf_timerfd.c:185]: (error)
> Uninitialized variable: event
> [osaf/libs/core/common/osaf_timerfd.c:186]:
> (error) Uninitialized variable: event
> [osaf/libs/core/common/osaf_timerfd.c:187]: (error) Uninitialized
> variable:
> event [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:25] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:25]: (style)
> Same
> expression on both sides of '<'.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:26] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:26]: (style)
> Same
> expression on both sides of '<='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:29] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:29]: (style)
> Same
> expression on both sides of '>='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:30] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:30]: (style)
> Same
> expression on both sides of '>'.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:70] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:70]: (style)
> Same
> expression on both sides of '<'.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:71] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:71]: (style)
> Same
> expression on both sides of '<='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:74] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:74]: (style)
> Same
> expression on both sides of '>='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:75] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:75]: (style)
> Same
> expression on both sides of '>'.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:97] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:97]: (style)
> Same
> expression on both sides of '<'.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:98] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:98]: (style)
> Same
> expression on both sides of '<='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:101] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:101]: (style)
> Same
> expression on both sides of '>='.
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:102] ->
> [osaf/libs/core/cplusplus/base/tests/time_compare_test.cc:102]: (style)
> Same
> expression on both sides of '>'. [osaf/libs/core/leap/hj_edp.c:169]:
> (style)
> The scope of the variable 'len' can be reduced.
> [osaf/libs/core/leap/hj_edp.c:352]: (style) The scope of the variable
> 'len'
> can be reduced. [osaf/libs/core/leap/hj_edp.c:352]: (style) The scope
> of the
> variable 'byte_cnt' can be reduced. [osaf/libs/core/leap/hj_edp.c:778]:
> (style) The scope of the variable 'byte_cnt' can be reduced.
> [osaf/libs/core/leap/hj_edp.c:1661]: (warning) Division by result of
> sizeof(). malloc() expects a size in bytes, did you intend to multiply
> instead? [osaf/libs/core/leap/hj_edp.c:1813]: (warning) Division by
> result
> of sizeof(). malloc() expects a size in bytes, did you intend to
> multiply
> instead? [osaf/libs/core/leap/hj_edu.c:132]: (style) The scope of the
> variable 'arguments' can be reduced. [osaf/libs/core/leap/hj_edu.c:284]:
> (style) The scope of the variable 'arguments' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:413]: (style) The scope of the variable
> 'dtype_attrb' can be reduced. [osaf/libs/core/leap/hj_edu.c:415]:
> (style)
> The scope of the variable 'cnt' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:2478]: (style) The scope of the variable
> 'lclfnd' can be reduced. [osaf/libs/core/leap/hj_edu.c:2528]: (style)
> The
> scope of the variable 'already_added' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:3244]: (style) The scope of the variable
> 'new_node' can be reduced. [osaf/libs/core/leap/hj_edu.c:3321]: (style)
> The
> scope of the variable 'key' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:3322]: (style) The scope of the variable
> 'pnode' can be reduced. [osaf/libs/core/leap/hj_edu.c:3447]: (style) The
> scope of the variable 'val' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:3499]: (style) The scope of the variable
> 'val'
> can be reduced. [osaf/libs/core/leap/hj_edu.c:3529]: (style) The scope
> of
> the variable 'i' can be reduced. [osaf/libs/core/leap/hj_edu.c:3626]:
> (style) The scope of the variable 'val' can be reduced.
> [osaf/libs/core/leap/hj_edu.c:3679]: (style) The scope of the variable
> 'val'
> can be reduced. [osaf/libs/core/leap/hj_edu.c:498]: (style) Variable
> 'admin_op' is assigned a value that is never used.
> [osaf/libs/core/leap/hj_edu.c:3328]: (style) Variable 'lcl_key' is
> assigned
> a value that is never used. [osaf/libs/core/leap/hj_edu.c:445]: (error)
> Uninitialized variable: admin_op [osaf/libs/core/leap/hj_edu.c:446]:
> (error)
> Uninitialized variable: admin_op [osaf/libs/core/leap/hj_edu.c:3296]:
> (error) Uninitialized variable: list_params
> [osaf/libs/core/leap/hj_enc.c:58]: (style) The scope of the variable
> 'p' can
> be reduced. [osaf/libs/core/leap/hj_hdl.c:231]: (style) The scope of the
> variable 'unit' can be reduced. [osaf/libs/core/leap/hj_hdl.c:271]:
> (style)
> The scope of the variable 'cell' can be reduced.
> [osaf/libs/core/leap/hj_hdl.c:311]: (style) The scope of the variable
> 'cell'
> can be reduced. [osaf/libs/core/leap/hj_hdl.c:547]: (style) The scope
> of the
> variable 'cell' can be reduced. [osaf/libs/core/leap/hj_hdl.c:613]:
> (style)
> The scope of the variable 'cell' can be reduced.
> [osaf/libs/core/leap/hj_hdl.c:617]: (style) The scope of the variable
> 'i'
> can be reduced. [osaf/libs/core/leap/hj_hdl.c:193]: (error)
> Uninitialized
> variable: ha [osaf/libs/core/leap/hj_hdl.c:194]: (error) Uninitialized
> variable: ha [osaf/libs/core/leap/hj_hdl.c:195]: (error) Uninitialized
> variable: ha [osaf/libs/core/leap/hj_hdl.c:196]: (error) Uninitialized
> variable: ha [osaf/libs/core/leap/hj_hdl.c:578]: (error) Uninitialized
> variable: hdl [osaf/libs/core/leap/hj_hdl.c:579]: (error) Uninitialized
> variable: hdl [osaf/libs/core/leap/hj_hdl.c:580]: (error) Uninitialized
> variable: hdl [osaf/libs/core/leap/hj_tmr.c:389]: (style) The scope of
> the
> variable 'tmr_info' can be reduced. [osaf/libs/core/leap/hj_tmr.c:425]:
> (style) The scope of the variable 'pres_tmr_info' can be reduced.
> [osaf/libs/core/leap/hj_tmr.c:471]: (style) The scope of the variable
> 'prev_tmr_info' can be reduced. [osaf/libs/core/leap/hj_ubaid.c:708]:
> (style) The scope of the variable 'p' can be reduced.
> [osaf/libs/core/leap/os_defs.c:505]: (style) The scope of the variable
> 'tmp_hdl' can be reduced. [osaf/libs/core/leap/os_defs.c:645]: (style)
> The
> scope of the variable 'file' can be reduced.
> [osaf/libs/core/leap/os_defs.c:773]: (style) The scope of the variable
> 'prot_flag' can be reduced. [osaf/libs/core/leap/os_defs.c:593]: (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:595]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:597]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:598]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:599]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:600]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:614]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:616]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:618]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:619]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:620]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:621]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:654]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:661]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:667]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:670]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:694]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:695]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:696]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:706]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/os_defs.c:707]:
> (error)
> Uninitialized variable: os_req [osaf/libs/core/leap/sysf_exc_scr.c:460]:
> (style) The scope of the variable 'exec_pid' can be reduced.
> [osaf/libs/core/leap/sysf_exc_scr.c:109]: (error) Uninitialized
> variable:
> info [osaf/libs/core/leap/sysf_exc_scr.c:110]: (error) Uninitialized
> variable: info [osaf/libs/core/leap/sysf_exc_scr.c:111]: (error)
> Uninitialized variable: info [osaf/libs/core/leap/sysf_exc_scr.c:146]:
> (error) Uninitialized variable: info
> [osaf/libs/core/leap/sysf_exc_scr.c:147]: (error) Uninitialized
> variable:
> info [osaf/libs/core/leap/sysf_exc_scr.c:148]: (error) Uninitialized
> variable: info [osaf/libs/core/leap/sysf_exc_scr.c:404]: (error)
> Uninitialized variable: pt_params [osaf/libs/core/leap/sysf_ipc.c:454]:
> (style) The scope of the variable 'inds_rmvd' can be reduced.
> [osaf/libs/core/leap/sysf_mem.c:854]: (style) The scope of the variable
> 'pub' can be reduced. [osaf/libs/core/leap/sysf_mem.c:856]: (style) The
> scope of the variable 'buflen' can be reduced.
> [osaf/libs/core/leap/sysf_mem.c:944]: (style) The scope of the variable
> 'buflen' can be reduced. [osaf/libs/core/leap/sysf_mem.c:1162]: (style)
> The
> scope of the variable 'i' can be reduced.
> [osaf/libs/core/leap/sysf_mem.c:1170]: (style) The scope of the variable
> 'dest' can be reduced. [osaf/libs/core/leap/sysf_mem.c:1478]: (style)
> The
> scope of the variable 'bufsize' can be reduced.
> [osaf/libs/core/leap/sysf_mem.c:1735]: (style) The scope of the variable
> 'len' can be reduced. [osaf/libs/core/leap/sysf_mem.c:1736]: (style) The
> scope of the variable 'dst' can be reduced.
> [osaf/libs/core/leap/sysf_mem.c:1917]: (style) The scope of the variable
> 'file' can be reduced. [osaf/libs/core/leap/sysf_mem.c:747]: (error)
> Uninitialized variable: l_util [osaf/libs/core/leap/sysf_tmr.c:390]:
> (style)
> The scope of the variable 'rc' can be reduced.
> [osaf/libs/core/leap/sysf_tmr.c:545]: (style) The scope of the variable
> 'free_tmr' can be reduced. [osaf/libs/core/leap/sysf_tmr.c:166]: (style)
> struct member 'sysf_tmr_cb::stats' is never used.
> [osaf/libs/core/leap/sysf_tsk.c:53]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:54]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:55]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:56]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:57]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:58]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:75]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:87]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:99]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:111]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:123]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/sysf_tsk.c:132]: (error) Uninitialized variable:
> task
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:74] ->
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:78]: (style) Variable 'rc'
> is
> reassigned a value before the old one has been used.
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:41]: (style) The scope of
> the
> variable 'temp' can be reduced.
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:123]: (style) The scope of
> the
> variable 'msg' can be reduced.
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:124]: (style) The scope of
> the
> variable 'prio' can be reduced.
> [osaf/libs/core/leap/tests/sysf_ipc_test.cc:126]: (style) The scope of
> the
> variable 'rc' can be reduced.
> [osaf/libs/core/leap/tests/sysf_tmr_test.cc:18]: (warning) Member
> variable
> 'SysfTmrTest::timers_' is not initialized in the constructor.
>
>
> Complete diffstat:
> ------------------
> Makefile.am | 2 +-
> osaf/libs/agents/saf/amfa/ava_hdl.cc | 1 -
> osaf/libs/common/ais/aisa_api.c | 2 +
> osaf/libs/core/common/daemon.c | 60
> ++++++++++++++++++++----------------
> osaf/libs/core/common/include/osaf_secutil.h | 14 +------
> osaf/libs/core/common/ncs_main_pub.c | 19 +++--------
> osaf/libs/core/common/nid_start_util.c | 4 +-
> osaf/libs/core/common/osaf_extended_name.c | 1 +
> osaf/libs/core/common/osaf_poll.c | 13 +------
> osaf/libs/core/common/osaf_secutil.c | 223
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------
> osaf/libs/core/common/osaf_timerfd.c | 2 +
> osaf/libs/core/cplusplus/base/tests/time_compare_test.cc | 12 +++++++
> osaf/libs/core/include/ncspatricia.h | 3 -
> osaf/libs/core/leap/hj_edp.c | 17 +++++-----
> osaf/libs/core/leap/hj_edu.c | 52
> ++++++++++++++------------------
> osaf/libs/core/leap/hj_enc.c | 2 +-
> osaf/libs/core/leap/hj_hdl.c | 29
> +++++++++--------
> osaf/libs/core/leap/hj_tmr.c | 9 +---
> osaf/libs/core/leap/hj_ubaid.c | 3 +-
> osaf/libs/core/leap/os_defs.c | 19 +++++------
> osaf/libs/core/leap/sysf_exc_scr.c | 27
> +++++++---------
> osaf/libs/core/leap/sysf_ipc.c | 4 +-
> osaf/libs/core/leap/sysf_mem.c | 9 +---
> osaf/libs/core/leap/sysf_tmr.c | 7 +---
> osaf/libs/core/leap/sysf_tsk.c | 7 ++++
> osaf/libs/core/leap/tests/sysf_ipc_test.cc | 18 +++++------
> osaf/libs/core/leap/tests/sysf_tmr_test.cc | 4 +-
> osaf/services/saf/glsv/gld/gld_api.c | 3 -
> osaf/services/saf/glsv/glnd/glnd_cb.c | 3 -
> osaf/services/saf/mqsv/mqd/mqd_api.c | 2 -
> osaf/services/saf/mqsv/mqnd/mqnd_init.c | 3 -
> 31 files changed, 264 insertions(+), 310 deletions(-)
>
>
> Testing Commands:
> -----------------
> make cppcheck
>
>
> Testing, Expected Results:
> --------------------------
> Reduced number of cppcheck warnings
>
>
> Conditions of Submission:
> -------------------------
> Ack from reviewer(s)
>
>
> Arch Built Started Linux distro
> -------------------------------------------
> mips n n
> mips64 n n
> x86 n n
> x86_64 y y
> powerpc n n
> powerpc64 n n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
> that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
> (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
> Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
> like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
> cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
> too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
> Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
> commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
> of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
> comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
> the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
> for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
> do not contain the patch that updates the Doxygen manual.
>
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
