Summary: amfd: allow lock and unlock operation on NoRed MW SI. [#1834]
Review request for Trac Ticket(s): #1834
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset d8a2f7c2d507d852893d902b5408d7b8fad28b00
Author: praveen.malv...@oracle.com
Date: Fri, 24 Jun 2016 11:02:00 +0530
amfd: allow lock and unlock operation on NoRed MW SI. [#1834]
In the reported issue, amfd crashes during deletion of MW NoRed SI while
standby SC is coming up.
Here requirement is to bring down a payload node and delete its related
configuration like node, MW SI, MW SU etc. As per AMF PR doc section
7.1.4 ,
SI must be locked before deleting it. Also AMF allows deletion of SI in
unlocked state if it is unassigned, but it is not the recommended way.
Since
lock operation on NoRed MW SI is not allowed, the only way to delete is
when
it is unassigned. This imposes another criterion to bring down the node
or
lock NoRed SU so that its MW SI gets unassigned and its deletion can
proceed. Even in this case also, AMF can pick the same SI and assign it
to
some other unassigned node or any node joining the cluster that time.
Thus
there is no gaurantee that SI will remain unassigned.
Patch allows lock and unlock admin op on MW NoRed SI accept the one
assigned
on active SC.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/si.cc | 20 +++++++++++++++++++-
1 files changed, 19 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Try to lock and unlock MW SI which is assigned on other than
active controller when cluster is stable from AMF perspective.
Testing, Expected Results:
--------------------------
Lock and unlock operation successful.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
