Hi Neelakanta, In patch 4, the case b) is ok since the "case 'B':" continues with "case 'A':" where pbe2 is set to true. "pbe2 = true;" in "case B:" is redundant.
Thanks, Zoran -----Original Message----- From: Neelakanta Reddy [mailto:[email protected]] Sent: Monday, June 27, 2016 7:26 AM To: Hung Duc Nguyen <[email protected]>; Zoran Milinkovic <[email protected]> Cc: [email protected] Subject: Re: [PATCH 0 of 5] Review Request for imm: Fix cppcheck warnings [#1883] Hi Hung, Reviewed and tested the patch series. Ack, with following comments: a) patch 1: 1. Add strdup to the following string : int cnt = strlen("OperationName is not supported")+1 b) patch 4: case 'B': - pbe2 = true; The value of pbe2, should not be removed. Instead use the if (!pbe2) or if (pbe2==false) /Neel. On 2016/06/22 10:00 AM, Hung Nguyen wrote: > Summary: imm: Fix cppcheck warnings [#1883] Review request for Trac > Ticket(s): 1883 Peer Reviewer(s): Zoran, Neel Pull request to: > Affected branch(es): 5.1 > Development branch: 5.1 > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > > changeset 2810dad99daa9a0a226db4282bc303b3283240ef > Author: Hung Nguyen <[email protected]> > Date: Tue, 21 Jun 2016 18:20:44 +0700 > > imm: Fix cppcheck incorrectStringBooleanError warnings [#1883] > > Fix cppcheck incorrectStringBooleanError warnings. > > changeset 998f6f5e3b793cfdb4e760f6f77b275982e85d36 > Author: Hung Nguyen <[email protected]> > Date: Tue, 21 Jun 2016 18:22:18 +0700 > > imm: Fix cppcheck invalidPrintfArgType_uint warnings [#1883] > > Fix cppcheck invalidPrintfArgType_uint warnings. > > changeset 0884e9e02d0ea96046f463cbf967843291c010ca > Author: Hung Nguyen <[email protected]> > Date: Tue, 21 Jun 2016 18:23:11 +0700 > > imm: Fix cppcheck nullPointer warnings [#1883] > > Fix cppcheck nullPointer warnings. > > changeset 1efee2d6d2aaec6d44a9f07e50b840609cb2ab79 > Author: Hung Nguyen <[email protected]> > Date: Tue, 21 Jun 2016 18:24:26 +0700 > > imm: Fix cppcheck redundantAssignInSwitch warnings [#1883] > > Fix cppcheck redundantAssignInSwitch warnings. > > changeset e8e735485b386fd63ae660681129e117f445af94 > Author: Hung Nguyen <[email protected]> > Date: Tue, 21 Jun 2016 18:25:02 +0700 > > imm: Fix cppcheck uselessAssignmentPtrArg warnings [#1883] > > Fix cppcheck uselessAssignmentPtrArg warnings. > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/imma/imma_oi_api.c | 1 - > osaf/libs/agents/saf/imma/imma_om_api.c | 8 ++++---- > osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 4 ++-- > osaf/services/saf/immsv/immnd/ImmModel.cc | 16 ++++------------ > osaf/services/saf/immsv/immnd/immnd_proc.c | 2 +- > osaf/services/saf/immsv/immpbed/immpbe.cc | 1 - > osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 2 +- > osaf/tools/safimm/immcfg/imm_cfg.c | 12 ++++++------ > osaf/tools/safimm/immcfg/imm_import.cc | 8 ++++---- > osaf/tools/safimm/src/immutil.c | 2 +- > samples/immsv/immutils/immutil.c | 2 +- > 11 files changed, 24 insertions(+), 34 deletions(-) > > > Testing Commands: > ----------------- > > > > Testing, Expected Results: > -------------------------- > > > > Conditions of Submission: > ------------------------- > Ack from reviewers. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
