Summary: amfd: add long DN support [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This set of patches added long DN support to AMFD.
changeset 44e1eb64739f52b6cc83263505ac7d55720b55b2
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 05 Jul 2016 17:50:16 +1000
amfd: replace SaNameT with string in include dir [#1642]
changeset 25079b2753e5cd7f5d367459f84af621d60f7656
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 05 Jul 2016 17:50:16 +1000
amfd: replace SaNameT with string [#1642]
Replace SaNameT with string in SG related files. Add support for long
DN.
changeset c33bf21fda32d2387435800b9914b8a385bff9f7
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 05 Jul 2016 17:50:16 +1000
amfd: replace SaNameT with string [#1642]
Replace utility functions that operated on C style strings with
std::string
equivalents.
changeset 7518f668092f66c1ab0b590319f8ddf09a710bbd
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 05 Jul 2016 17:50:16 +1000
amfd: enable long DN support [#1642]
changeset b1ffc693e435a021f90b82234c12aa55140215ff
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 05 Jul 2016 17:50:16 +1000
amfd: replace SaNameT with string [#1642]
Add support for long DN
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/Makefile.am | 2 +-
osaf/services/saf/amf/amfd/app.cc | 90
+++++++++++++-------------
osaf/services/saf/amf/amfd/apptype.cc | 67 ++++++++++---------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 257
++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------
osaf/services/saf/amf/amfd/ckpt_enc.cc | 123
+++++++++++++++++-------------------
osaf/services/saf/amf/amfd/ckpt_updt.cc | 119
++++++++++++++++++----------------
osaf/services/saf/amf/amfd/clm.cc | 32 ++++----
osaf/services/saf/amf/amfd/cluster.cc | 14 ++--
osaf/services/saf/amf/amfd/comp.cc | 251
+++++++++++++++++++++++++++++++++++++++------------------------------------
osaf/services/saf/amf/amfd/compcstype.cc | 183
+++++++++++++++++++++++++++---------------------------
osaf/services/saf/amf/amfd/comptype.cc | 103
+++++++++++++++---------------
osaf/services/saf/amf/amfd/csi.cc | 297
+++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
osaf/services/saf/amf/amfd/csiattr.cc | 243
+++++++++++++++++++++++++++++++++---------------------------------------
osaf/services/saf/amf/amfd/cstype.cc | 78
+++++++++--------------
osaf/services/saf/amf/amfd/ctcstype.cc | 72 +++++++++++----------
osaf/services/saf/amf/amfd/hlt.cc | 33 ++++-----
osaf/services/saf/amf/amfd/hlttype.cc | 31 ++++----
osaf/services/saf/amf/amfd/imm.cc | 389
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------
osaf/services/saf/amf/amfd/include/Makefile.am | 1 -
osaf/services/saf/amf/amfd/include/app.h | 8 +-
osaf/services/saf/amf/amfd/include/apptype.h | 10 +-
osaf/services/saf/amf/amfd/include/cb.h | 4 +-
osaf/services/saf/amf/amfd/include/ckpt.h | 4 +-
osaf/services/saf/amf/amfd/include/cluster.h | 8 +-
osaf/services/saf/amf/amfd/include/comp.h | 58 +++++++++--------
osaf/services/saf/amf/amfd/include/csi.h | 26 +++---
osaf/services/saf/amf/amfd/include/evt.h | 22 +++---
osaf/services/saf/amf/amfd/include/imm.h | 21 +++---
osaf/services/saf/amf/amfd/include/node.h | 21 +++---
osaf/services/saf/amf/amfd/include/ntf.h | 34 +++++-----
osaf/services/saf/amf/amfd/include/pg.h | 2 +-
osaf/services/saf/amf/amfd/include/proc.h | 22 +++---
osaf/services/saf/amf/amfd/include/sg.h | 9 +-
osaf/services/saf/amf/amfd/include/sgtype.h | 10 +-
osaf/services/saf/amf/amfd/include/si.h | 12 +-
osaf/services/saf/amf/amfd/include/si_dep.h | 16 ++--
osaf/services/saf/amf/amfd/include/su.h | 18 ++--
osaf/services/saf/amf/amfd/include/susi.h | 14 ++--
osaf/services/saf/amf/amfd/include/sutcomptype.h | 4 +-
osaf/services/saf/amf/amfd/include/sutype.h | 6 +-
osaf/services/saf/amf/amfd/include/svctype.h | 4 +-
osaf/services/saf/amf/amfd/include/svctypecstype.h | 6 +-
osaf/services/saf/amf/amfd/include/timer.h | 5 +-
osaf/services/saf/amf/amfd/include/util.h | 17 +++--
osaf/services/saf/amf/amfd/main.cc | 9 ++
osaf/services/saf/amf/amfd/ndfsm.cc | 24 +++---
osaf/services/saf/amf/amfd/ndproc.cc | 50 +++++++-------
osaf/services/saf/amf/amfd/node.cc | 276
+++++++++++++++++++++++++++++++++++++++-------------------------------------------
osaf/services/saf/amf/amfd/nodegroup.cc | 260
+++++++++++++++++++++++++++++++++++++++++------------------------------------
osaf/services/saf/amf/amfd/nodeswbundle.cc | 51 ++++++++-------
osaf/services/saf/amf/amfd/ntf.cc | 123
+++++++++++++++++++-----------------
osaf/services/saf/amf/amfd/pg.cc | 4 +-
osaf/services/saf/amf/amfd/role.cc | 2 +-
osaf/services/saf/amf/amfd/sg.cc | 271
+++++++++++++++++++++++++++++++++++++++++---------------------------------------
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 414
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 60 +++++++++---------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 196
+++++++++++++++++++++++++++++-----------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 250
+++++++++++++++++++++++++++++++++++++-------------------------------------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 148
++++++++++++++++++++++----------------------
osaf/services/saf/amf/amfd/sgproc.cc | 210
+++++++++++++++++++++++++++++++-------------------------------
osaf/services/saf/amf/amfd/sgtype.cc | 85
++++++++++++------------
osaf/services/saf/amf/amfd/si.cc | 274
++++++++++++++++++++++++++++++++++++++++++----------------------------------------
osaf/services/saf/amf/amfd/si_dep.cc | 297
+++++++++++++++++++++++++++++++++++++++--------------------------------------------------
osaf/services/saf/amf/amfd/siass.cc | 138
+++++++++++++++++++++-------------------
osaf/services/saf/amf/amfd/sirankedsu.cc | 173
+++++++++++++++++++++------------------------------
osaf/services/saf/amf/amfd/su.cc | 533
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------
osaf/services/saf/amf/amfd/sutcomptype.cc | 29 ++++----
osaf/services/saf/amf/amfd/sutype.cc | 73 +++++++++++----------
osaf/services/saf/amf/amfd/svctype.cc | 48 +++++++------
osaf/services/saf/amf/amfd/svctypecstypes.cc | 43 ++++++------
osaf/services/saf/amf/amfd/util.cc | 377
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------
71 files changed, 3670 insertions(+), 3494 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
Ack from devs or 2 weeks from now.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
