Summary: amfnd: enable long DN support [#1642] Review request for Trac Ticket(s): 1642 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch is to add long DN support to amfnd. Besides that, it also refactors patricia trees to std::map [Minh did that] and most of SaNameT to std::string. changeset 86a7cc021c8a3cc8a328ce6e9a25c05a71d3ca76 Author: Long HB Nguyen<[email protected]> Date: Mon, 11 Jul 2016 16:07:16 +0700 amfnd: enable long DN support [#1642] This patch refactors the patricia tree to std::map [Minh], replaces most of SaNameT to std::string and supports for long DN. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/Makefile.am | 2 +- osaf/services/saf/amf/amfnd/amfnd.cc | 55 +++++++------ osaf/services/saf/amf/amfnd/cbq.cc | 58 +++++++------- osaf/services/saf/amf/amfnd/chc.cc | 68 +++++++---------- osaf/services/saf/amf/amfnd/clc.cc | 197 +++++++++++++++++++++++++-------------------------- osaf/services/saf/amf/amfnd/clm.cc | 44 ++++++----- osaf/services/saf/amf/amfnd/comp.cc | 438 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------- osaf/services/saf/amf/amfnd/compdb.cc | 579 ++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------------------- osaf/services/saf/amf/amfnd/cpm.cc | 18 ++-- osaf/services/saf/amf/amfnd/di.cc | 163 +++++++++++++++++++++-------------------- osaf/services/saf/amf/amfnd/err.cc | 106 +++++++++++++-------------- osaf/services/saf/amf/amfnd/evt.cc | 10 ++- osaf/services/saf/amf/amfnd/hcdb.cc | 271 +++++++++++++++++---------------------------------------------------- osaf/services/saf/amf/amfnd/imm.cc | 9 +- osaf/services/saf/amf/amfnd/include/avnd.h | 3 +- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 17 ++-- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 79 ++++++++++--------- osaf/services/saf/amf/amfnd/include/avnd_di.h | 6 +- osaf/services/saf/amf/amfnd/include/avnd_hc.h | 11 +- osaf/services/saf/amf/amfnd/include/avnd_mds.h | 28 ------- osaf/services/saf/amf/amfnd/include/avnd_pg.h | 19 +--- osaf/services/saf/amf/amfnd/include/avnd_proxy.h | 14 +-- osaf/services/saf/amf/amfnd/include/avnd_su.h | 26 ++---- osaf/services/saf/amf/amfnd/include/avnd_util.h | 1 + osaf/services/saf/amf/amfnd/main.cc | 43 +++------- osaf/services/saf/amf/amfnd/mds.cc | 247 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- osaf/services/saf/amf/amfnd/mon.cc | 6 +- osaf/services/saf/amf/amfnd/pg.cc | 72 ++++++++++-------- osaf/services/saf/amf/amfnd/pgdb.cc | 82 +++++++------------- osaf/services/saf/amf/amfnd/proxy.cc | 108 +++++++++++++++------------- osaf/services/saf/amf/amfnd/proxydb.cc | 113 +++++----------------------- osaf/services/saf/amf/amfnd/sidb.cc | 151 ++++++++++++++++++++++----------------- osaf/services/saf/amf/amfnd/su.cc | 119 ++++++++++++++---------------- osaf/services/saf/amf/amfnd/sudb.cc | 105 ++++++++++---------------- osaf/services/saf/amf/amfnd/susm.cc | 269 ++++++++++++++++++++++++++++++++++----------------------------------- osaf/services/saf/amf/amfnd/term.cc | 24 ++++- osaf/services/saf/amf/amfnd/tmr.cc | 8 +- osaf/services/saf/amf/amfnd/util.cc | 58 ++++++++++++-- 38 files changed, 1692 insertions(+), 1935 deletions(-) Testing Commands: ----------------- Running amf_demo with long DNs. Testing, Expected Results: -------------------------- Working properly as with normal DNs. Conditions of Submission: ------------------------- Ack from devs or 2 weeks from now. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
