Hi Mahesh! The files lgs_clm.cc and lgs_clm.h seem to be missing in these patches. Could you please resend?
thanks, Anders Widell On 08/02/2016 07:18 AM, mahesh.va...@oracle.com wrote: > Summary:lga: agent Cluster Membership (CLM) integration [#1638] V2 > Review request for Trac Ticket(s): #1638 > Peer Reviewer(s):Vu, Lennart,Anders Widell > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset d7c494e940160d474a89dffffbafbc2cbf058678 > Author: A V Mahesh <mahesh.va...@oracle.com> > Date: Tue, 02 Aug 2016 10:41:21 +0530 > > lga: agent Cluster Membership (CLM) integration [#1638] V2 > > V2 patch: > > Incorporated Anders Widell and Vu review comments , for more details > see the review comments posted on V1 patch. Description: > > Form CLM integration is supported from Log Service A.02.02. > > At-least a A.02.02 LGA client will check CLM membership status of > client's > node. old LGA clients A.02.01 are always clm member. > > This patch enhanced the log service for Unavailability of the Log > Service > API on a Non-Member Node which will fail with SA_AIS_ERR_UNAVAILABLE. > > After this patch the Log Service does not provide service to processes > on > cluster nodes that are not in the cluster membership. > > If the node rejoins the cluster membership, processes executing on the > node > will be able to reinitialize new library handles and use the entire set > of > Log Service APIs that operate on these new handles; however, invocation > of > APIs that operate on handles acquired by any process before the node > left > the membership will continue to fail with SA_AIS_ERR_UNAVAILABLE (or > with > the special treatment described above for asynchronous calls) with the > exception of saLogFinalize(), which is used to free the library handles > and > all resources associated with these handles. Hence, it is recommended > for > the processes to finalize the library handles as soon as the processes > detect that the node left the membership. > > Detailed README will be provide soon. > > Following are expected Log Service API behavior : > > Case1: On Non-Member Node, Log Service API will fail with code > SA_AIS_ERR_UNAVAILABLE (31) Case2: On Member Node after recovered from > Non- > Member Node, Log Service API will fail with code SA_AIS_ERR_UNAVAILABLE > (31) > Case3: Non-Member Node + (Headless) Log Service API will fail with code > SA_AIS_ERR_UNAVAILABLE (31) Case4: On Non-Member Node + (Headless) + > (Head > Joined) Log Service API will fail with code SA_AIS_ERR_UNAVAILABLE (31) > > changeset dc881a3c478480e44bb163e75a463baaa9430482 > Author: A V Mahesh <mahesh.va...@oracle.com> > Date: Tue, 02 Aug 2016 10:42:11 +0530 > > lgs: director Cluster Membership (CLM) integration [#1638] V2 > > changeset 1742284de46e241c2785744399830017b64ba3df > Author: A V Mahesh <mahesh.va...@oracle.com> > Date: Tue, 02 Aug 2016 10:42:58 +0530 > > logtest: change related to Cluster Membership (CLM) integration [#1638] > V2 > Test : > > #amf-adm lock safNode=PL-4,safCluster=myClmCluster > > <saLogStreamOpen_2> failed with code SA_AIS_ERR_UNAVAILABLE (31). > > #amf-adm unlock safNode=PL-4,safCluster=myClmCluster > > <saLogStreamOpen_2> failed with code SA_AIS_ERR_UNAVAILABLE (31). > > #amf-adm lock safNode=PL-4,safCluster=myClmCluster + (SC-1 & Sc-2 > /etc/init.d/opensafd stop) > > <saLogStreamOpen_2> failed with code SA_AIS_ERR_UNAVAILABLE (31) > > # amf-adm lock safNode=PL-4,safCluster=myClmCluster + ((SC-1 & Sc-2 > /etc/init.d/opensafd stop)) + ((SC-1 & Sc-2 /etc/init.d/opensafd > start) + amf-adm unlock safNode=PL-4,safCluster=myClmCluster > > <saLogStreamOpen_2> failed with code SA_AIS_ERR_UNAVAILABLE (31) > > Expected but currently The Imm APIs are NOT working error - > saImmOmInitialize FAILED: SA_AIS_ERR_LIBRARY (2) > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/lga/lga.h | 2 + > osaf/libs/agents/saf/lga/lga_api.c | 47 > +++++++++++++++++++++++++++++++++++++++++++++ > osaf/libs/agents/saf/lga/lga_mds.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > osaf/libs/agents/saf/lga/lga_util.c | 2 + > osaf/libs/common/logsv/include/lgsv_defs.h | 6 ++++- > osaf/libs/common/logsv/include/lgsv_msg.h | 17 ++++++++++++--- > osaf/services/saf/logsv/lgs/Makefile.am | 7 ++++- > osaf/services/saf/logsv/lgs/lgs_cb.h | 15 ++++++++++++++ > osaf/services/saf/logsv/lgs/lgs_evt.cc | 143 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > osaf/services/saf/logsv/lgs/lgs_evt.h | 2 + > osaf/services/saf/logsv/lgs/lgs_main.cc | 28 > +++++++++++++++++++++++++++ > osaf/services/saf/logsv/lgs/lgs_mds.cc | 38 > +++++++++++++++++++++++++++++++++++- > osaf/services/saf/logsv/lgs/lgs_util.cc | 83 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/logsv/saflogtest.c | 2 +- > 14 files changed, 452 insertions(+), 9 deletions(-) > > > Testing Commands: > ----------------- > <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> > > > Testing, Expected Results: > -------------------------- > <<PASTE COMMAND OUTPUTS / TEST RESULTS>> > > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
