Summary: CKPT: Support DNs longer than 255 bytes [#1574]
Review request for Trac Ticket(s): 1574
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 4d12e373df37e584ef89ab2de425da2aca605234
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpd: Add support for extended SaNameT [#1574]
changeset fff91d9209edc72d57fdaf2b7eae4f139f6e882b
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpnd: Add support for extended SaNameT v1 [#1574]
changeset 1514ff6d5f37070c5faa776409f3455d257e188d
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpa: Add support for extended SaNameT v1 [#1574]
changeset 0d2ab3645b20083a65838d666e3c0778e1e715ef
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpsv: Add new message to support extended SaNameT v1 [#1574] New
messages
supporting extended SaNameT are introduce. Encoding and decoding
funtions
for them are also included.
changeset 13de643d5e887f68178651ba9610c486dbfde82b
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpd: Add new mbcsv messages supporting extended SaNameT v1 [#1574] New
MBCSV
messages supporting extended SaNameT and their encoding/decoding
functions
are included.
changeset de69ca58258b72dc4a97f48ca2e68e9b023d0e5f
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and
CPA
v1 [#1574]
changeset 9d469821de69d8b5252010bf3b5d04ab84b00ba9
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
ckpt: Add new test cases to verify long DN feature on CPSV v1 [#1574]
changeset 3f57a04ecd76a5449add80ea5898cc441d968103
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Tue, 02 Aug 2016 15:16:03 +0700
imported patch 1574_cpnd_support_recover_shm_version_0_v3.patch
Complete diffstat:
------------------
osaf/libs/agents/saf/cpa/Makefile.am | 1 +
osaf/libs/agents/saf/cpa/cpa_api.c | 68 +++++++---
osaf/libs/agents/saf/cpa/cpa_db.c | 2 +
osaf/libs/agents/saf/cpa/cpa_mds.c | 8 +-
osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
osaf/libs/common/cpsv/cpsv_evt.c | 505
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
osaf/libs/common/cpsv/include/cpa.h | 1 +
osaf/libs/common/cpsv/include/cpa_cb.h | 2 +-
osaf/libs/common/cpsv/include/cpa_proc.h | 2 +-
osaf/libs/common/cpsv/include/cpd.h | 1 +
osaf/libs/common/cpsv/include/cpd_cb.h | 17 +-
osaf/libs/common/cpsv/include/cpd_imm.h | 4 +-
osaf/libs/common/cpsv/include/cpd_mem.h | 25 +++-
osaf/libs/common/cpsv/include/cpd_proc.h | 2 +-
osaf/libs/common/cpsv/include/cpnd.h | 1 +
osaf/libs/common/cpsv/include/cpnd_cb.h | 5 +-
osaf/libs/common/cpsv/include/cpnd_init.h | 3 +-
osaf/libs/common/cpsv/include/cpsv_evt.h | 24 +++
osaf/libs/common/cpsv/include/cpsv_shm.h | 24 +++-
osaf/services/saf/cpsv/cpd/Makefile.am | 1 +
osaf/services/saf/cpsv/cpd/cpd_amf.c | 7 +-
osaf/services/saf/cpsv/cpd/cpd_db.c | 95 +++++++-------
osaf/services/saf/cpsv/cpd/cpd_evt.c | 107 +++++++++++-----
osaf/services/saf/cpsv/cpd/cpd_imm.c | 268
++++++++++++++++++++++++++++++------------
osaf/services/saf/cpsv/cpd/cpd_main.c | 7 +
osaf/services/saf/cpsv/cpd/cpd_mbcsv.c | 31 ++++-
osaf/services/saf/cpsv/cpd/cpd_mds.c | 86 ++++++++++++-
osaf/services/saf/cpsv/cpd/cpd_proc.c | 184 +++++++++++++++--------------
osaf/services/saf/cpsv/cpd/cpd_red.c | 6 +-
osaf/services/saf/cpsv/cpd/cpd_sbevt.c | 57 +++-----
osaf/services/saf/cpsv/cpnd/Makefile.am | 1 +
osaf/services/saf/cpsv/cpnd/cpnd_db.c | 6 +-
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 101 +++++++++++----
osaf/services/saf/cpsv/cpnd/cpnd_main.c | 7 +
osaf/services/saf/cpsv/cpnd/cpnd_mds.c | 86 ++++++++++++-
osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 92 ++++++++++---
osaf/services/saf/cpsv/cpnd/cpnd_res.c | 823
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
tests/cpsv/Makefile.am | 1 +
tests/cpsv/test_cpa.c | 180 ++++++++++++++++++++++++++++-
tests/cpsv/test_cpa_util.c | 16 ++-
tests/cpsv/test_cpsv.h | 6 +
tests/cpsv/test_cpsv_conf.h | 3 +
42 files changed, 2236 insertions(+), 632 deletions(-)
Testing Commands:
-----------------
Start all SCs and PLs
Log in to SC-1
Run ckpttest
Turn on long DN: immcfg -a longDnsAllowed=1
opensafImm=opensafImm,safApp=safImmService
Run ckpttest
Do again above steps with PL-3
Testing, Expected Results:
--------------------------
All test cases passed
Conditions of Submission:
-------------------------
ACK from maintainer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
