Summary:osaf: support for SAF SaTimeT variable in MDS transport changes [#1658]
Review request for Trac Ticket(s): #1658
Peer Reviewer(s):Ramesh & All Service owners
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services y
Core libraries y
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 1d40f2b5245f680c8bdfbf901bfce0b6a5c770dc
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:22:38 +0530
immsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
Issue : In current implementation their is a mismatch of variable sizes
between SAF API accepting SaTimeT variable type for timeout ( 64 bit)
and
MDS transport implementation accepting (32 bit) timeout variable , the
MDS
transport should adopt the size of the timeout parameter from 32 bits
to 64
bits.
Fix : Now MDS provide interface to accept SaTimeT type timeout variable
from
SAF APIS
changeset ce12efeaa4dd72485346d1b23d3879f6e93b91df
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:23:21 +0530
clmsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 16d0a7459c35bc2783a71867019c9e96a020701c
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:23:49 +0530
lgs: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset be6d4a01e7477feefd49575c0d2027fe481af5b4
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:24:14 +0530
cpsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset bfbb54051e5514b04ea667656a7b3edb630e022d
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:24:35 +0530
ntfsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 949f9e16dbd2151f19a25ead52ce2bdfef781d70
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:24:54 +0530
mds: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 3b4cd3da2ab51c37cf5914fa789b80435a683617
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:25:11 +0530
leap: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 0635be0683e6a0076c159ee83d0391dd2bf1a93c
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:25:31 +0530
plmsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 09c2ace577252d199edc5c7fae5755290ae80168
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:26:08 +0530
smf: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset f7388038b68fc560a30cf7187add95a2fed95dba
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:26:41 +0530
amf: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset b9fcc7c8f3f7d4784675023cf987c9ef4359971d
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:27:05 +0530
mqsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset 40464c4348defb5040da215fc8bb48707664514d
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:27:23 +0530
glsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
changeset dc6b1a5113ebff51d5ef062ebc3b77beefe10ccf
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 09 Aug 2016 11:27:41 +0530
edsv: support for SAF SaTimeT timeout variable in MDS transport [#1658]
Complete diffstat:
------------------
osaf/libs/agents/saf/clma/clma.h | 2 +-
osaf/libs/agents/saf/clma/clma_api.c | 10 +---------
osaf/libs/agents/saf/clma/clma_mds.c | 2 +-
osaf/libs/agents/saf/cpa/cpa_api.c | 18
+++++-------------
osaf/libs/agents/saf/cpa/cpa_mds.c | 2 +-
osaf/libs/agents/saf/cpa/cpa_tmr.c | 6 +++---
osaf/libs/agents/saf/eda/eda_mds.c | 2 +-
osaf/libs/agents/saf/eda/eda_saf_api.c | 7 ++++---
osaf/libs/agents/saf/gla/gla_api.c | 6 +++---
osaf/libs/agents/saf/gla/gla_mds.c | 2 +-
osaf/libs/agents/saf/gla/gla_tmr.c | 6 +++---
osaf/libs/agents/saf/imma/imma.h | 2 +-
osaf/libs/agents/saf/imma/imma_cb.h | 4 ++--
osaf/libs/agents/saf/imma/imma_mds.c | 2 +-
osaf/libs/agents/saf/imma/imma_mds.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 12 ++++++------
osaf/libs/agents/saf/imma/imma_om_api.c | 44
++++++++++++++++++--------------------------
osaf/libs/agents/saf/imma/imma_proc.c | 2 +-
osaf/libs/agents/saf/lga/lga.h | 2 +-
osaf/libs/agents/saf/lga/lga_api.c | 4 ++--
osaf/libs/agents/saf/lga/lga_mds.c | 2 +-
osaf/libs/agents/saf/lga/lga_state.c | 4 ++--
osaf/libs/agents/saf/mqa/mqa_api.c | 20
++++++++++----------
osaf/libs/agents/saf/mqa/mqa_mds.c | 6 +++---
osaf/libs/agents/saf/ntfa/ntfa.h | 2 +-
osaf/libs/agents/saf/ntfa/ntfa_api.c | 12 ++++++------
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 2 +-
osaf/libs/common/cpsv/include/cpa_mds.h | 2 +-
osaf/libs/common/cpsv/include/cpa_tmr.h | 2 +-
osaf/libs/common/cpsv/include/cpd_mds.h | 2 +-
osaf/libs/common/cpsv/include/cpd_tmr.h | 2 +-
osaf/libs/common/cpsv/include/cpnd_init.h | 4 ++--
osaf/libs/common/edsv/include/eda_mds.h | 2 +-
osaf/libs/common/edsv/include/eds_mds.h | 2 +-
osaf/libs/common/glsv/include/gla_mds.h | 2 +-
osaf/libs/common/mqsv/include/mqa_def.h | 6 +++---
osaf/libs/common/mqsv/include/mqnd_mds.h | 2 +-
osaf/libs/common/plmsv/include/plma.h | 2 +-
osaf/libs/common/plmsv/include/plms.h | 2 +-
osaf/libs/common/plmsv/include/plms_hrb.h | 2 +-
osaf/libs/common/plmsv/plms_common_mds.c | 2 +-
osaf/libs/common/smfsv/include/smfsv_evt.h | 2 +-
osaf/libs/common/smfsv/smfsv_evt.c | 2 +-
osaf/libs/core/common/include/osaf_poll.h | 4 ++--
osaf/libs/core/common/include/osaf_secutil.h | 2 +-
osaf/libs/core/common/osaf_poll.c | 9 +++++----
osaf/libs/core/common/osaf_secutil.c | 8 ++++----
osaf/libs/core/include/mds_papi.h | 14 +++++++-------
osaf/libs/core/include/ncs_osprm.h | 2 +-
osaf/libs/core/include/ncs_tmr.h | 8 ++++----
osaf/libs/core/include/ncssysf_tmr.h | 4 ++--
osaf/libs/core/leap/hj_tmr.c | 22
+++++++++++-----------
osaf/libs/core/leap/include/sysf_exc_scr.h | 2 +-
osaf/libs/core/leap/sysf_tmr.c | 10 +++++-----
osaf/libs/core/mds/include/mds_dl_api.h | 4 ++--
osaf/libs/core/mds/mds_c_api.c | 2 +-
osaf/libs/core/mds/mds_c_sndrcv.c | 7 ++++---
osaf/libs/core/mds/mds_main.c | 4 ++--
osaf/services/infrastructure/dtms/dtm/dtm_main.c | 2 +-
osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 2 +-
osaf/services/infrastructure/dtms/include/dtm_cb.h | 2 +-
osaf/services/infrastructure/nid/nodeinit.h | 2 +-
osaf/services/saf/amf/amfd/timer.cc | 4 ++--
osaf/services/saf/amf/amfnd/clc.cc | 2 +-
osaf/services/saf/clmsv/nodeagent/main.c | 2 +-
osaf/services/saf/cpsv/cpd/cpd_mds.c | 2 +-
osaf/services/saf/cpsv/cpd/cpd_tmr.c | 6 +++---
osaf/services/saf/cpsv/cpnd/cpnd_mds.c | 4 ++--
osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 +-
osaf/services/saf/cpsv/cpnd/cpnd_tmr.c | 4 ++--
osaf/services/saf/edsv/eds/eds_ckpt.c | 2 +-
osaf/services/saf/edsv/eds/eds_mds.c | 2 +-
osaf/services/saf/edsv/eds/eds_tmr.c | 8 ++++----
osaf/services/saf/glsv/gld/gld_tmr.c | 4 ++--
osaf/services/saf/glsv/glnd/glnd_res.c | 2 +-
osaf/services/saf/glsv/glnd/glnd_tmr.c | 4 ++--
osaf/services/saf/immsv/immd/immd_mds.c | 2 +-
osaf/services/saf/immsv/immd/immd_mds.h | 2 +-
osaf/services/saf/mqsv/mqd/mqd_tmr.c | 4 ++--
osaf/services/saf/mqsv/mqnd/mqnd_mds.c | 2 +-
osaf/services/saf/mqsv/mqnd/mqnd_tmr.c | 2 +-
osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb_mds.c | 4 ++--
osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c | 2 +-
tests/mds/mdstipc.h | 14 +++++++-------
tests/mds/mdstipc_conf.c | 14 +++++++-------
85 files changed, 203 insertions(+), 224 deletions(-)
Testing Commands:
-----------------
Test is in-piratical , but still we can send timeout value of max of SaTimeT
size
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
