Ack, code review only. The ticket no is incorrect in the subject should be #1894/Thanks HansN
-----Original Message----- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 29 juni 2016 02:48 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr...@oracle.com; praveen.malv...@oracle.com; Gary Lee <gary....@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] AMFD: Correct the size of synchronizing node after headless [#1984] osaf/services/saf/amf/amfd/ndfsm.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) If more than 2 payloads are joining from headless, amfd will think all nodes have already been synced even there's still one being in headless sync period. The patch corrects the conditional statement that fixes the size of nodes being synchronized. diff --git a/osaf/services/saf/amf/amfd/ndfsm.cc b/osaf/services/saf/amf/amfd/ndfsm.cc --- a/osaf/services/saf/amf/amfd/ndfsm.cc +++ b/osaf/services/saf/amf/amfd/ndfsm.cc @@ -298,7 +298,7 @@ void avd_node_up_evh(AVD_CL_CB *cb, AVD_ uint32_t rc_node_up; avnd->node_up_msg_count++; rc_node_up = avd_count_node_up(cb); - if (rc_node_up == sync_nd_size-1) { + if (rc_node_up == sync_nd_size) { if (cb->node_sync_tmr.is_active) { avd_stop_tmr(cb, &cb->node_sync_tmr); TRACE("stop NodeSync timer"); ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
