Hi Mahesh, Thanks for your testing. I missed this one. I will send new one after fixing it.
Regards, Canh. -----Original Message----- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Friday, August 12, 2016 1:38 PM To: Canh Van Truong; Vu Minh Nguyen; Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913] Hi Canh Van Truong, On 8/11/2016 11:50 AM, Canh Van Truong wrote: > 2) Remove abort (safassert) in test case and handle it as test case failed. Still seeing abort (safassert) ============================================================================ ==================== Suite 2: Log Service Operations 1 PASSED saLogStreamOpen_2() system stream OK; 2 PASSED saLogStreamOpen_2() notification stream OK; 3 PASSED saLogStreamOpen_2() alarm stream OK; 4 PASSED Create app stream OK; 5 PASSED Create and open app stream; ........................................ 47 PASSED saLogStreamOpen_2 with invalid filename; 48 PASSED saLogStreamOpen_2 with maxLogRecordSize > MAX_RECSIZE, ERR; 49 PASSED saLogStreamOpen_2 with maxLogRecordSize < 150, ERR; 50 PASSED saLogStreamOpen_2 with stream number out of the limitation, ERR; 51 PASSED logInitialize then logFinalize multiple times. keep MDS connection, OK; error: in tet_saLogStreamOpen_2.c at 919: SA_AIS_ERR_ACCESS (11), expected OUT_OF_RANGE - exiting ============================================================================ ==================== -AVM On 8/11/2016 11:50 AM, Canh Van Truong wrote: > Summary: log: improve test cases for log service [#1913] Review > request for Trac Ticket(s): #1913 Peer Reviewer(s): Vu, Mahesh, > Lennart Pull request to: Vu Affected branch(es): default Development > branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset 66ce76934620ec6230cfc90da3082167d72392b6 > Author: Canh Van Truong <canh.v.tru...@dektech.com.au> > Date: Fri, 05 Aug 2016 15:21:55 +0700 > > log: improve test cases for log service [#1913] > > The patch fixes to improve following cases: > > 1) The APIs may return TRY_AGAIN, this may not be a fault. Writing some > wrapper functions here to handle TRY_AGAIN case for log API. > > 2) Remove abort (safassert) in test case and handle it as test case failed. > > 3) Some test cases (in testsuite 4) have dependence on other test cases. > Make them independency. > > 4) Some test cases (in testsuite 4, 5, 6) change setting such as IMM > attributes values and don't restore them back to previous. Get the > attributes values before changing attributes, then restore its to previous > values at end of test cases. > > 5) Some test cases in testsuite 6 change attributes base on the present > value of logMaxLogrecsize without read the present value of its. They use > constanst values (=1024). Changing to read logMaxLogrecsize value and use > it. > > > Complete diffstat: > ------------------ > tests/logsv/logtest.c | 89 +++- > tests/logsv/logtest.h | 89 +++- > tests/logsv/tet_LogOiOps.c | 2163 ++++++++++++++++++++++++++++++++++++++++++++++++---------------------------- -------- > tests/logsv/tet_Log_recov.c | 95 +-- > tests/logsv/tet_log_longDN.c | 1 - > tests/logsv/tet_saLogDispatch.c | 9 +- > tests/logsv/tet_saLogFinalize.c | 11 +- > tests/logsv/tet_saLogInitialize.c | 26 +- > tests/logsv/tet_saLogLimitGet.c | 19 +- > tests/logsv/tet_saLogSelectionObjectGet.c | 13 +- > tests/logsv/tet_saLogStreamClose.c | 24 +- > tests/logsv/tet_saLogStreamOpenAsync_2.c | 15 +- > tests/logsv/tet_saLogStreamOpen_2.c | 546 +++++++++++++------- > tests/logsv/tet_saLogWriteLog.c | 23 +- > tests/logsv/tet_saLogWriteLogAsync.c | 461 ++++++++++++----- > tests/logsv/tet_saLogWriteLogCallbackT.c | 110 +++- > 16 files changed, 2266 insertions(+), 1428 deletions(-) > > > Testing Commands: > ----------------- > Run all test cases. > > > Testing, Expected Results: > -------------------------- > All test case passed. > > > Conditions of Submission: > ------------------------- > Ack from reviewers > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
