Hi Hoang,
ACK, Please Update README
Note : tested default functionality , LONG DN functionality not tested
in full fledged.
-AVM
On 8/18/2016 12:48 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes {#1574}
> Review request for Trac Ticket(s): 1574
> Peer Reviewer(s): [email protected]; [email protected]
> Pull request to: [email protected]
> Affected branch(es): default
> Development branch: default
>
> --------------------------------
> Impacted area Impact y/n
> --------------------------------
> Docs n
> Build system n
> RPM/packaging n
> Configuration files n
> Startup scripts n
> SAF services y
> OpenSAF services n
> Core libraries n
> Samples n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
>
> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpd: Add support for extended SaNameT [#1574] v3
>
> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpnd: Add support for extended SaNameT [#1574] v3
>
> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpa: Add support for extended SaNameT [#1574] v1
>
> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpsv: Add new message to support extended SaNameT [#1574] v3
>
> changeset 29df19302186b3275ad06db00dc62f275dea25e1
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>
> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and
> CPA
> [#1574] v4
>
> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1
>
> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
> Author: Hoang Vo <[email protected]>
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
> cpnd: add support for shm recovery for in-service update without
> restarting
> node [#1574] v1
>
>
> Complete diffstat:
> ------------------
> osaf/libs/agents/saf/cpa/Makefile.am | 1 +
> osaf/libs/agents/saf/cpa/cpa_api.c | 48 ++++--
> osaf/libs/agents/saf/cpa/cpa_db.c | 2 +
> osaf/libs/agents/saf/cpa/cpa_mds.c | 4 +-
> osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
> osaf/libs/common/cpsv/cpsv_evt.c | 440
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> osaf/libs/common/cpsv/include/cpa.h | 1 +
> osaf/libs/common/cpsv/include/cpa_cb.h | 2 +-
> osaf/libs/common/cpsv/include/cpa_proc.h | 2 +-
> osaf/libs/common/cpsv/include/cpd.h | 1 +
> osaf/libs/common/cpsv/include/cpd_cb.h | 17 +-
> osaf/libs/common/cpsv/include/cpd_imm.h | 4 +-
> osaf/libs/common/cpsv/include/cpd_mem.h | 25 +++-
> osaf/libs/common/cpsv/include/cpd_proc.h | 2 +-
> osaf/libs/common/cpsv/include/cpnd.h | 1 +
> osaf/libs/common/cpsv/include/cpnd_cb.h | 5 +-
> osaf/libs/common/cpsv/include/cpnd_init.h | 3 +-
> osaf/libs/common/cpsv/include/cpsv_evt.h | 10 +
> osaf/libs/common/cpsv/include/cpsv_shm.h | 24 +++-
> osaf/services/saf/cpsv/cpd/Makefile.am | 1 +
> osaf/services/saf/cpsv/cpd/cpd_amf.c | 7 +-
> osaf/services/saf/cpsv/cpd/cpd_db.c | 95 +++++++-------
> osaf/services/saf/cpsv/cpd/cpd_evt.c | 103 ++++++++++-----
> osaf/services/saf/cpsv/cpd/cpd_imm.c | 268
> ++++++++++++++++++++++++++++++------------
> osaf/services/saf/cpsv/cpd/cpd_main.c | 7 +
> osaf/services/saf/cpsv/cpd/cpd_mbcsv.c | 31 ++++-
> osaf/services/saf/cpsv/cpd/cpd_mds.c | 84 ++++++++++++-
> osaf/services/saf/cpsv/cpd/cpd_proc.c | 180
> ++++++++++++++--------------
> osaf/services/saf/cpsv/cpd/cpd_red.c | 6 +-
> osaf/services/saf/cpsv/cpd/cpd_sbevt.c | 57 +++-----
> osaf/services/saf/cpsv/cpnd/Makefile.am | 1 +
> osaf/services/saf/cpsv/cpnd/cpnd_db.c | 6 +-
> osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 73 ++++++++---
> osaf/services/saf/cpsv/cpnd/cpnd_main.c | 7 +
> osaf/services/saf/cpsv/cpnd/cpnd_mds.c | 86 ++++++++++++-
> osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 84 +++++++++---
> osaf/services/saf/cpsv/cpnd/cpnd_res.c | 823
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
> tests/cpsv/Makefile.am | 1 +
> tests/cpsv/test_cpa.c | 180
> ++++++++++++++++++++++++++++-
> tests/cpsv/test_cpa_util.c | 16 ++-
> tests/cpsv/test_cpsv.h | 6 +
> tests/cpsv/test_cpsv_conf.h | 3 +
> 42 files changed, 2088 insertions(+), 631 deletions(-)
>
>
> Testing Commands:
> -----------------
> Start all SCs and PLs
> Login SC-1
> Run ckpttest
> Turn on long DN support: immcfg -a longDnsAllowed=1
> opensafImm=opensafImm,safApp=safImmService
> Run ckpttest again
> Login PL-3
> Run ckpttest
> Turn on long DN support: immcfg -a longDnsAllowed=1
> opensafImm=opensafImm,safApp=safImmService
> Run ckpttest again
>
> Testing, Expected Results:
> --------------------------
> All test cases passed
>
> Conditions of Submission:
> -------------------------
> ACK from maintainer
>
> Arch Built Started Linux distro
> -------------------------------------------
> mips n n
> mips64 n n
> x86 n n
> x86_64 y y
> powerpc n n
> powerpc64 n n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
> that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
> (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
> Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
> like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
> cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
> too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
> Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
> commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
> of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
> comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
> the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
> for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
> do not contain the patch that updates the Doxygen manual.
>
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
