Summary: smfd: Merge rolling to singlestep procedures for several nodes
Review request for Trac Ticket(s): #1685
Peer Reviewer(s): lennart, reddy
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>>
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Still missing:
si-swap handling to be added
oi for openSafSmfExecControl to be added
changeset 95f9f432c9d79c29a2ba971add5ad490f28ca0a3
Author: Rafael Odzakow <rafael.odza...@ericsson.com>
Date: Tue, 23 Aug 2016 10:02:51 +0200
smfd: Merge rolling to singlestep procedures for several nodes [#1685]
This commit enables the balanced mode feature. This mode changes the execution
of rolling procedures to be merged into one or several single steps that are
spread out across the cluster nodes. This feature is used to give a faster
upgrade time compared to rolling procedures upgrading one node at a time,
possibly several times for each node. By splittting the procedures it into
several single steps across the nodes a total service outage can be avoided.
Added Files:
------------
osaf/services/saf/smfsv/smfd/SmfExecControl.cc
osaf/services/saf/smfsv/smfd/SmfExecControl.h
Complete diffstat:
------------------
osaf/services/saf/smfsv/config/smfsv_classes.xml | 13 +++++
osaf/services/saf/smfsv/smfd/Makefile.am | 6 +-
osaf/services/saf/smfsv/smfd/SmfCampState.cc | 125
++++++++-----------------------------------------------
osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 78
++++++++++++++++++++--------------
osaf/services/saf/smfsv/smfd/SmfCampaign.hh | 1 +
osaf/services/saf/smfsv/smfd/SmfExecControl.cc | 399
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/smfsv/smfd/SmfExecControl.h | 56
+++++++++++++++++++++++++
osaf/services/saf/smfsv/smfd/SmfProcState.cc | 7 ++-
osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc | 32 ++++++++------
osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.hh | 24 ++++------
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 14 ++++--
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.hh | 20 +++++++-
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh | 13 ++---
osaf/services/saf/smfsv/smfd/smfd.h | 2 +-
14 files changed, 605 insertions(+), 185 deletions(-)
Testing Commands:
-----------------
Campaign with rolling procedures is attached to the ticket. Run a campaign with
rolling procedures on payloads and enable the balanced mode:
immcfg -c OpenSafSmfExecControl -a procExecMode=2
openSafSmfExecControl=MergeCampToSS2
immcfg -a numberOfSingleSteps=2 -a nodesForSingleStep=PL-3 -a
nodesForSingleStep=PL-4 openSafSmfExecControl=MergeCampToSS2
immcfg -a openSafSmfExecControl=openSafSmfExecControl=MergeCampToSS2
smfConfig=1,safApp=safSmfService
In this configuration we can expect to run one single step procedures on each
of the payloads specified.
Testing, Expected Results:
--------------------------
campaign should have executed all steps according to configuration
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
