Summary: amfd: fix cppcheck errors [#1642] Review request for Trac Ticket(s): #1642 Peer Reviewer(s): <<LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE>> Pull request to: Minh Affected branch(es): default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Converting some data members to std::string causes cppcheck errors such as: [osaf/services/saf/amf/amfd/ndproc.cc:314]: (error) Using 'memcpy' on struct that contains a 'std::string'. [osaf/services/saf/amf/amfd/ndproc.cc:358]: (error) Using 'memcpy' on struct that contains a 'std::string'. [osaf/services/saf/amf/amfd/role.cc:560]: (error) Using 'memset' on struct that contains a 'std::string'. changeset 535e80218b1a9e3fb45ea7cd8df77d3e4d646bc2 Author: Gary Lee <[email protected]> Date: Mon, 29 Aug 2016 16:07:35 +1000 amfd: fix cppcheck errors [#1642] fix cppcheck errors introduced by changing various members of structs to std::string Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +- osaf/services/saf/amf/amfd/ndproc.cc | 8 ++++---- osaf/services/saf/amf/amfd/role.cc | 3 +-- 3 files changed, 6 insertions(+), 7 deletions(-) Testing Commands: ----------------- make cppcheck Testing, Expected Results: -------------------------- no "errors" in amfd Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
