Summary: smf: SMF does not handle AMF long DN&RDN support Review request for Trac Ticket(s): #1968 Peer Reviewer(s): [email protected], [email protected] Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset b8b30362ca68218e126f8e48fa916b9feeb90f60 Author: Lennart Lund <[email protected]> Date: Mon, 29 Aug 2016 09:05:48 +0200 smf: SMF does not handle AMF long DN&RDN support [#1968] Allow all IMM objects to have long DN Complete diffstat: ------------------ osaf/services/saf/smfsv/smfd/SmfCampaignXmlParser.cc | 36 +++++++++++++++++++++++++----------- osaf/services/saf/smfsv/smfd/SmfUtils.cc | 29 ++++++++++++++++++++--------- osaf/services/saf/smfsv/smfd/smfd.h | 1 - osaf/services/saf/smfsv/smfd/smfd_cb.h | 1 + osaf/services/saf/smfsv/smfd/smfd_main.c | 2 ++ osaf/services/saf/smfsv/smfnd/smfnd_main.c | 3 +++ 6 files changed, 51 insertions(+), 21 deletions(-) Testing Commands: ----------------- Execute a campaign with long DNs for AMF objects Example for a long_dn_campaign.xml: safSmfCampaign="safSmfCampaign=ThisIsA300CharLongRDNaaaaaaa..... <upgradeProcedure safSmfProcedure="safSmfProc=LongDnTestNodeSCThisIsA300CharLongRDNaaaaaaaaaaaaaaaaaaaa... Testing, Expected Results: -------------------------- Campaign shall be completed with no fail Example: # smf-state camp safSmfCampaign=LennartLock,safApp=safSmfService state=EXECUTION_COMPLETED(5) error='' # Conditions of Submission: ------------------------- Ack from reviewers. Also more testing with long DN AMF objects Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
