Summary:dtm: TCP Improve node failFast with TCP_USER_TIMEOUT [#2014]
Review request for Trac Ticket(s): #2014
Peer Reviewer(s): Jonas, Anders widell
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): defulat, 5.1
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e445b6f5e498771a62ef880ff0fde968cb9c0eed
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Wed, 14 Sep 2016 09:39:59 +0530
dtm: TCP Improve node failFast with TCP_USER_TIMEOUT [#2014] Since Linux
kernel above and equal 3.18, TCP sockets have an option called
TCP_USER_TIMEOUT.
TCP_USER_TIMEOUT is a TCP level socket option that takes an unsigned
int,
when grater than 0, to specify the maximum amount of time in ms that
transmitted data may remain unacknowledged before TCP will forcefully
close
the corresponding connection and return ETIMEDOUT to the application.
If 0
is given, TCP will continue to use the system default.
Increasing the TCP_USER_TIMEOUT allows a TCP connection to survive
extended
periods without end-to-end connectivity. Decreasing the user timeouts
allows
applications to fail fast if so desired. Otherwise it may take upto 20
minutes with the current system defaults in a normal WAN environment.
This option, TCP_USER_TIMEOUT will override keep-alive to determine
when to
close a connection due to keep-alive failure.
Defaulted to 1.5 sec to match other transport protocols (TIPC) supported
Opensaf.
Try to tune & test the DTM_TCP_USER_TIMEOUT=1500 to higher and lower
value
in dtmd.conf
Complete diffstat:
------------------
osaf/services/infrastructure/dtms/config/dtmd.conf | 12 ++++++++++++
osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 11 +++++++++++
osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 19
++++++++++++++++++-
osaf/services/infrastructure/dtms/include/dtm.h | 4 ++++
osaf/services/infrastructure/dtms/include/dtm_cb.h | 1 +
5 files changed, 46 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
