On 15-Sep-16 4:10 PM, minh chau wrote:
> Hi Praveen,
>
> ack with minor comment.
> 1-I think 2 places: avd_sg_admin_state_set() and
> AVD_SG::set_admin_state(), to be changed?
I did not know that there are two function doing same thing.
Do you know the reason, Why there were not merged or new one introduced 
when SG was converted to class. Surely, SG pointer is available to the 
caller for both functions.

> 2-Those functions exit with TRACE_LEAVE()
I intentionally avoided both TRACE_ENTER() and TRACE_LEAVE() so that no 
trace is generated at all. We are doing this way in 
AVD_SU::set_pres_state() and may be other places.


Anyways I will do the changes before pushing.

Thanks,
Praveen
>
> Thanks,
> Minh
> On 15/09/16 19:58, praveen.malv...@oracle.com wrote:
>>   osaf/services/saf/amf/amfd/sg.cc |  2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/osaf/services/saf/amf/amfd/sg.cc
>> b/osaf/services/saf/amf/amfd/sg.cc
>> --- a/osaf/services/saf/amf/amfd/sg.cc
>> +++ b/osaf/services/saf/amf/amfd/sg.cc
>> @@ -1643,6 +1643,8 @@ void avd_sg_admin_state_set(AVD_SG* sg,
>>       SaAmfAdminStateT old_state = sg->saAmfSGAdminState;
>>
>>       osafassert(state <= SA_AMF_ADMIN_SHUTTING_DOWN);
>> +    if (sg->saAmfSGAdminState == state)
>> +        return;
>>       TRACE_ENTER2("%s AdmState %s => %s", sg->name.c_str(),
>>               avd_adm_state_name[old_state], avd_adm_state_name[state]);
>>       saflog(LOG_NOTICE, amfSvcUsrName, "%s AdmState %s => %s",
>> sg->name.c_str(),
>>
>

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to