Summary: log: fix ER syslog when running logtest 5 2 [#1864]
Review request for Trac Ticket(s): #1864
Peer Reviewer(s): Vu, Lennart, Mahesh
Pull request to: Vu
Affected branch(es): 4.7.x, 5.0.x, 5.1.x, default
Development branch: default

Impacted area       Impact y/n
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   y
 Other                   n

Comments (indicate scope for each "y" above):

changeset 3e9c9af1418505eef1fd5165dbec9d10d5e9ff7b
Author: Canh Van Truong <>
Date:   Fri, 16 Sep 2016 14:44:01 +0700

        log: fix ER syslog when running logtest 5 2 [#1864]

         Not wait for apply callback in logtest 5 2 done before removing test
        directory (in this test case, it changes 'logRootDirectory' attribute, 
        there are action of renames files)

        The patch adds a check loop to make sure all apply callback (rename log
        files) done before removing the log test directory.

Complete diffstat:
 tests/logsv/tet_LogOiOps.c |  11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

Testing Commands:
Run test case:
logtest 5 2

Testing, Expected Results:
Test case passed.

Conditions of Submission:
Ack from reviewers.

Arch      Built     Started    Linux distro
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n

Reviewer Checklist:
[Submitters: make sure that your review doesn't trigger any checkmarks!]

Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.

Opensaf-devel mailing list

Reply via email to