Ack, code review only.
Thanks, Praveen On 22-Sep-16 2:11 PM, Canh Van Truong wrote: > osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 2 +- > osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > > When unsubscribe() and finalize() do in parallel, ntfd may process finalize > request first. > It delete client and anything relate to this client. When ntfd processes > unsubscribe request, > It can't find clientId in the list and the error is printed out here. > > The patch makes to convert LOG_ER to LOG_WA. > > diff --git a/osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc > b/osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc > --- a/osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc > +++ b/osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc > @@ -517,7 +517,7 @@ void NtfAdmin::subscriptionRemoved(unsig > } > else > { > - LOG_ER("NtfAdmin::subscriptionRemoved client %u not found", clientId); > + LOG_WA("NtfAdmin::subscriptionRemoved client %u not found", clientId); > } > > // notifications do not need to be sent on that subscription, remove > diff --git a/osaf/services/saf/ntfsv/ntfs/NtfClient.cc > b/osaf/services/saf/ntfsv/ntfs/NtfClient.cc > --- a/osaf/services/saf/ntfsv/ntfs/NtfClient.cc > +++ b/osaf/services/saf/ntfsv/ntfs/NtfClient.cc > @@ -226,7 +226,7 @@ void NtfClient::subscriptionRemoved(SaNt > } > else > { > - LOG_ER( "NtfClient::subscriptionRemoved subscription" > + LOG_WA( "NtfClient::subscriptionRemoved subscription" > " %u not found", subscriptionId); > } > if (activeController()) { > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel