Summary: dtm: Convert transport monitor script to a daemon [#2035] V2
Review request for Trac Ticket(s): 2035
Peer Reviewer(s): Mahesh
Pull request to: 
Affected branch(es): default(5.2)
Development branch: default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        y
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------
Changes in V2 patch:

* Updated opensaf.spec.in and opensafd.in according to review comments
* Fixed shellcheck warnings in osaf-transport.in

changeset 47c52cb831e52ac6ba2bcd55f442a610f9c44642
Author: Anders Widell <anders.wid...@ericsson.com>
Date:   Thu, 22 Sep 2016 13:08:46 +0200

        dtm: Convert transport monitor script to a daemon [#2035]

        Convert the osaf-transport-monitor shell script into a daemon called
        osaftransportd. The functionality of this new daemon is (should be) 
exactly
        the same as the functionality of the shell script that it replaces.


Complete diffstat:
------------------
 configure.ac                                                                |  
  3 ++-
 opensaf.spec.in                                                             |  
  4 ++--
 osaf/services/infrastructure/dtms/Makefile.am                               |  
  3 +--
 osaf/services/infrastructure/dtms/scripts/Makefile.am                       |  
  3 +--
 osaf/services/infrastructure/dtms/scripts/osaf-transport-monitor.in         |  
 82 
----------------------------------------------------------------------------------
 osaf/services/infrastructure/dtms/scripts/osaf-transport.in                 |  
 45 +++++++++++++++++++++++++++++++--------------
 osaf/services/infrastructure/dtms/transport/Makefile.am                     |  
 41 +++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/main.cc                         |  
 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/Makefile.am               |  
 45 +++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/mock_logtrace.cc          |  
 34 ++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/mock_logtrace.h           |  
 23 +++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/mock_osaf_poll.cc         |  
 26 ++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/mock_osaf_poll.h          |  
 38 ++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/tests/transport_monitor_test.cc |  
109 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/transport_monitor.cc            |  
 95 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/dtms/transport/transport_monitor.h             |  
 92 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/infrastructure/nid/scripts/opensafd.in                        |  
  6 +-----
 17 files changed, 593 insertions(+), 108 deletions(-)


Testing Commands:
-----------------
make check


Testing, Expected Results:
--------------------------
* No errors detected by the unit tests.
* MDS log rotation and dtm supervision should work as before.

Conditions of Submission:
-------------------------
Ack from reviewer(s)


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to