Hi all, Do you have any comments on this documentation change?
Thanks, Minh On 22/09/16 15:20, Minh Hon Chau wrote: > Summary: AMF: Update README for SC Absence feature [#2033] > Review request for Trac Ticket(s): 2033 > Peer Reviewer(s): AMF devs > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): 5.1, default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs y > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset 486b3871b3a376e47c4f066ede4e4562c4d8c699 > Author: minh-chau <minh.c...@dektech.com.au> > Date: Thu, 22 Sep 2016 15:18:23 +1000 > > AMF: Update PR doc for SC Absence feature [#2033] Rephrase Headless to > SC > absence, plus documentation for admin continuation > > Link to document for review > https://sourceforge.net/p/opensaf/tickets/_discu > ss/thread/3f0beb7d/a191/attachment/OpenSAF_AMF_PR_2033.odt > > changeset 1dc6270fa071e864a55ee34c86ec155cb820ddde > Author: minh-chau <minh.c...@dektech.com.au> > Date: Thu, 22 Sep 2016 15:18:23 +1000 > > AMF: Update README for SC Absence feature [#2033] Rephrase Headless to > SC > absence, plus documentation for admin continuation > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/README_HEADLESS | 151 > +++++++++++++++++++++++++++--------------------------- > 1 files changed, 76 insertions(+), 75 deletions(-) > > > Testing Commands: > ----------------- > <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> > > > Testing, Expected Results: > -------------------------- > <<PASTE COMMAND OUTPUTS / TEST RESULTS>> > > > Conditions of Submission: > ------------------------- > ack from reviewer > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
