Summary: amfnd: send recovery request to amfd for term-failed PI su [#2047] V2 Review request for Trac Ticket(s): #2047 Peer Reviewer(s): AMF devs Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- If a PI SU contains more than one NPI comps, then SU FSM cleans up only PI comps and not the NPI. In order to raise a su-failover request, all comps should be terminated. V1 patch works well if only one NPI comps is present. This V2 handles other case also. Also corrected log at one place. changeset ba8894711879b5f3f68b18baced5014466658636 Author: Praveen Malviya <[email protected]> Date: Mon, 03 Oct 2016 12:52:21 +0530 amfnd: send recovery request to amfd for term-failed PI su [#2047] V2 A SU having one NPI and one PI comp moved to term-failed state during fresh assignments and repair admin opreration does not work. It was NPI comp that faulted. When SG is unlocked, AMFND initiates active assignments by instantiating the NPI component and sending CSI set callback to PI comp. After instantiation failure of NPI comp, AMFND tries to clean up the component. Cleanup fails. AMFND marks comp and SU in TERM_FAILED state and terminates PI comp also. But AMFND neither responds to AMFD for the completion of assignment nor it sends any recovery request. Because of this SG remains unstable in REALIGN state. In this state, no admin operation is allowed. Patch solves the problem to send a recovery request to AMFD, so that it deletes the assignments and marks SG stable. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 5 +++ osaf/services/saf/amf/amfnd/di.cc | 2 +- osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +- osaf/services/saf/amf/amfnd/su.cc | 14 +++++++++ osaf/services/saf/amf/amfnd/susm.cc | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------ 5 files changed, 102 insertions(+), 11 deletions(-) Testing Commands: ----------------- Tested as per description of ticket.(more than one NPIs also) Also tested AMFND crash reported in comment. Testing, Expected Results: -------------------------- Passed and no crash observed. Observed #538 in case of assigned PI comp faults. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
