Summary: uml: Update UML to Linux 4.8 [#2089]
Review request for Trac Ticket(s): 2089
Peer Reviewer(s): Hans
Pull request to: 
Affected branch(es): opensaf-5.0.x, opensaf-5.1.x, default(5.2)
Development branch: default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   y


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset d8300f5f2a5df78bda658d9045a0815d0161ecbf
Author: Anders Widell <[email protected]>
Date:   Mon, 03 Oct 2016 15:30:32 +0200

        uml: Update UML to Linux 4.8 [#2089]

        * Update Linux to version 4.8
        * Improve robustness of the nodestart and nodestop commands
        * Add OSAF_UML_DYNAMIC_MAC option to select between static and dynamic 
MAC
        address assignment


Complete diffstat:
------------------
 tools/cluster_sim_uml/README                        |     6 +
 tools/cluster_sim_uml/opensaf                       |   161 +++++++++++-------
 tools/cluster_sim_uml/uml/bin/uml_start             |    12 +-
 tools/cluster_sim_uml/uml/build_uml                 |     4 +-
 tools/cluster_sim_uml/uml/config/busybox-1.24.2     |     4 +-
 tools/cluster_sim_uml/uml/config/linux-4.7.2-i686   |  1242 
--------------------------------------------------------------------------------------------------------------------------------------------
 tools/cluster_sim_uml/uml/config/linux-4.7.2-x86_64 |  1212 
-----------------------------------------------------------------------------------------------------------------------------------------
 tools/cluster_sim_uml/uml/config/linux-4.8-i686     |  1271 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/cluster_sim_uml/uml/config/linux-4.8-x86_64   |  1240 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 2631 insertions(+), 2521 deletions(-)


Testing Commands:
-----------------
* build and start UML
* try the OSAF_UML_DYNAMIC_MAC environment variable


Testing, Expected Results:
--------------------------
UML should start. MAC addresses should be static or dynamic depending on the
option selected.



Conditions of Submission:
-------------------------
Ack from reviewer(s)


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to