Hi Anders,

Reviewed the patch.
Ack from me.

Thanks,
Zoran

-----Original Message-----
From: Anders Widell 
Sent: den 20 oktober 2016 12:53
To: reddy.neelaka...@oracle.com; Zoran Milinkovic 
<zoran.milinko...@ericsson.com>; Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Fix error handling path when imma_sync_with_immnd 
fails [#2131]

 osaf/libs/agents/saf/imma/imma_init.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Since we have called imma_mds_register() at the point where
imma_sync_with_immnd() is called, we must call imma_mds_unregister() in the 
error handling path.

diff --git a/osaf/libs/agents/saf/imma/imma_init.c 
b/osaf/libs/agents/saf/imma/imma_init.c
--- a/osaf/libs/agents/saf/imma/imma_init.c
+++ b/osaf/libs/agents/saf/imma/imma_init.c
@@ -167,7 +167,7 @@ static uint32_t imma_create(NCSMDS_SVC_I
 
        if (imma_sync_with_immnd(cb) != NCSCC_RC_SUCCESS) {
                /* Needed to prevent endless TRY_AGAIN loop for first client. 
*/ 
-               goto mds_reg_fail;
+               goto edu_init_fail;
        }
 
        /* EDU initialisation ABT: Dont exactly know why we need this but... */

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to