Summary: amfnd: clean proxy if proxy and proxied are not in the same SU [#2169] Review request for Trac Ticket(s): #2169 Peer Reviewer(s): Amf Dev Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 13585f8f543960aed090d9344e6d640c9872551e Author: Nagendra Kumar<[email protected]> Date: Tue, 08 Nov 2016 13:57:12 +0530 amfnd: clean proxy if proxy and proxied are not in the same SU [#2169] Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 17 ++++++++++++++++- 1 files changed, 16 insertions(+), 1 deletions(-) Testing Commands: ----------------- 1. Use proxy demo available in samples/amf/proxy/. 2. Unlock proxy adn proxied using test.sh 3. Run the below commands to kill proxy component twice: pkill -9 proxy pkill -9 proxy 4. Lock SU1: amf-adm lock safSu=1,safSg=2N,safApp=Proxy 5. Unlock SU1: amf-adm unlock safSu=1,safSg=2N,safApp=Proxy Testing, Expected Results: -------------------------- After step #3, Su1 is restarted and re-assigned assignments. After step #4, proxy SU assignments are removed and proxied components are moved into Orphan state. After step #5, proxy gets assingments and proxied are moved into Instantiated state. PM_SC-1:/home/nagu/views/staging/samples/amf/proxy # amf-state siass safSISU=safSu=SC-1\,safSg=2N\,safApp=OpenSAF,safSi=SC-2N,safApp=OpenSAF saAmfSISUHAState=ACTIVE(1) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) safSISU=safSu=SC-1\,safSg=NoRed\,safApp=OpenSAF,safSi=NoRed1,safApp=OpenSAF saAmfSISUHAState=ACTIVE(1) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) safSISU=safSu=1\,safSg=2N\,safApp=Proxy,safSi=1,safApp=Proxy saAmfSISUHAState=ACTIVE(1) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) safSISU=safSu=1\,safSg=2N\,safApp=Proxied,safSi=1,safApp=Proxied saAmfSISUHAState=ACTIVE(1) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) PM_SC-1:/home/nagu/views/staging/samples/amf/proxy # immlist -a saAmfCompPresenceState safComp=1,safSu=1,safSg=2N,safApp=Proxied saAmfCompPresenceState=3 PM_SC-1:/home/nagu/views/staging/samples/amf/proxy # immlist -a saAmfCompPresenceState safComp=2,safSu=1,safSg=2N,safApp=Proxied saAmfCompPresenceState=3 Conditions of Submission: ------------------------- Ack from Amf Dev Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
