Ack, code review only.

Thanks,
Praveen

On 07-Nov-16 8:41 AM, Gary Lee wrote:
>  osaf/services/saf/amf/amfd/main.cc |  3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> avd_node_failover() will delete the current node and invalidate the
> iterator. We need to increment the iterator first.
>
> diff --git a/osaf/services/saf/amf/amfd/main.cc 
> b/osaf/services/saf/amf/amfd/main.cc
> --- a/osaf/services/saf/amf/amfd/main.cc
> +++ b/osaf/services/saf/amf/amfd/main.cc
> @@ -415,8 +415,9 @@ static void handle_event_in_failover_sta
>                * failover completes
>                */
>               for (std::map<uint32_t, AVD_AVND *>::const_iterator it = 
> node_id_db->begin();
> -                             it != node_id_db->end(); it++) {
> +                             it != node_id_db->end();) {
>                       AVD_AVND *node = it->second;
> +                     ++it;
>                       bool fover_done = false;
>                       if (AVD_AVND_STATE_ABSENT == node->node_state) {
>                               /* Check whether this node failover has been
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to