Ack code review only.
Thanks,
Praveen
On 10-Nov-16 8:09 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/su.cc | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> The original reported problem occurred probably because an SU
> was added between the standby director reading from IMM and becoming an
> applier.
>
> After the fix for #2112, this scenario should not occur. So we can
> just add an osafassert to ensure SU is found.
>
> diff --git a/osaf/services/saf/amf/amfd/su.cc
> b/osaf/services/saf/amf/amfd/su.cc
> --- a/osaf/services/saf/amf/amfd/su.cc
> +++ b/osaf/services/saf/amf/amfd/su.cc
> @@ -1817,6 +1817,7 @@ static void su_ccb_apply_modify_hdlr(str
> TRACE_ENTER2("CCB ID %llu, '%s'", opdata->ccbId,
> osaf_extended_name_borrow(&opdata->objectName));
>
> su = su_db->find(Amf::to_string(&opdata->objectName));
> + osafassert(su != nullptr);
>
> while ((attr_mod = opdata->param.modify.attrMods[i++]) != nullptr) {
> /* Attribute value removed */
>
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
