Hi Hung, Reviewed all patches, and tested if patches can be compiled.
Ack from me to all patches. Thanks, Zoran -----Original Message----- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 3 november 2016 12:00 To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 5] Review Request for imm: Compile the IMM library using the C++ compiler [#2142] Summary: imm: Compile the IMM library using the C++ compiler [#2142] Review request for Trac Ticket(s): 2142 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.2 Development branch: 5.2 -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 2a00f46102c46d227d6050fe8991d88eb86b903f Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> Date: Wed, 02 Nov 2016 11:23:40 +0700 imm: Compile the IMM library using the C++ compiler [#2142] Compile the IMM library using the C++ compiler. changeset 48f7f2ba7b9d4d091d0e230fc1d55e724e8fc628 Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> Date: Wed, 02 Nov 2016 11:23:40 +0700 imm: Fix "crosses initialization" errors [#2142] Fix "crosses initialization" errors. changeset 4539872836e8771009194bb02881e21d9ad68135 Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> Date: Wed, 02 Nov 2016 11:23:40 +0700 imm: Fix "invalid conversion" errors. [#2142] Fix "invalid conversion" errors. changeset 4feae1a1f865c5e1ca1db15d49dc0c53a5e60588 Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> Date: Wed, 02 Nov 2016 11:23:40 +0700 imm: Fix "comparison between signed and unsigned integer" errors [#2142] Fix "comparison between signed and unsigned integer" errors. changeset 32c3655fbd2baa8b9e87dbba6c6834135d573d97 Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> Date: Wed, 02 Nov 2016 11:23:40 +0700 imm: Fix linkage errors [#2142] Fix linkage errors. Complete diffstat: ------------------ osaf/libs/agents/saf/imma/Makefile.am | 24 ++++++++++++--------- osaf/libs/agents/saf/imma/imma_cb.h | 2 +- osaf/libs/agents/saf/imma/imma_db.c | 12 ++++------ osaf/libs/agents/saf/imma/imma_init.c | 5 +--- osaf/libs/agents/saf/imma/imma_mds.c | 4 +- osaf/libs/agents/saf/imma/imma_oi_api.c | 43 +++++++++++++++++++------------------- osaf/libs/agents/saf/imma/imma_om_api.c | 169 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------- osaf/libs/agents/saf/imma/imma_proc.c | 106 ++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------- osaf/libs/agents/saf/imma/imma_proc.h | 8 +++--- osaf/libs/core/mds/include/mds_dl_api.h | 9 ++++++++ osaf/libs/saf/libSaImm/Makefile.am | 4 +- osaf/libs/saf/libSaImm/libSaImmOm.map | 14 +++++++----- 12 files changed, 206 insertions(+), 194 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
