Summary: amfd: si-swap timeout during multiple switchover test [#2190] Review request for Trac Ticket(s): #2190 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): 5.0, 5.1, 5.2 Development branch: 5.2
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- IMM jobs are put in a queue to be performed later. When a si-swap on safSi=SC-2N,safApp=OpenSAF is performed, there may be a chance that the return code for si-swap operation has not been returned before OI is disconnected. In that case, admin operation returns timeout (SA_AIS_ERR_TIMEOUT). changeset 7a51e509f6b2ce2e2f0f63663f2e3d75d1bf4553 Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> Date: Wed, 16 Nov 2016 17:32:59 +0700 amfd: fix si-swap timeout [#2190] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/imm.cc | 22 ++++++++++++++++++++++ osaf/services/saf/amf/amfd/include/imm.h | 2 ++ osaf/services/saf/amf/amfd/role.cc | 5 +++++ 3 files changed, 29 insertions(+), 0 deletions(-) Testing Commands: ----------------- As the ticket. Testing, Expected Results: -------------------------- si-swap successfully. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel