Summary: AMFD: Return SA_AIS_ERR_NO_RESOURCES on si_ccb_complete if SG is unstable [#2184] Review request for Trac Ticket(s): 2184 Peer Reviewer(s): AMF devs Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 1cac06815919c891e085cf6c2307861b7673a673 Author: Minh Hon Chau <[email protected]> Date: Wed, 23 Nov 2016 21:06:40 +1100 AMFD: Return SA_AIS_ERR_NO_RESOURCES on si_ccb_complete if SG is unstable [#2184] Issue command immcfg to change saAmfSIPrefActiveAssignments while SG is unstable, AMF currently returns SA_AIS_ERR_BAD_OPERATION and error string as validation abort. As result, client stops retrying till SG becomes stable. Ideally AMFD should return SA_AIS_ERR_TRY_AGAIN so it will be consistent with other cases where admin operations hits unstable SG. But SA_AIS_ERR_TRY_AGAIN is not a valid return code for SaImmOiCcbCompletedCallbackT at this moment, so this patch returns SA_AIS_ERR_NO_RESOURCES so that error string would be "resource abort: Completed validation fails (Error code: 18)", and client will catch this error string for another try. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/si.cc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Testing Commands: ----------------- - Loading NwayActive models, unlock-in SUs - delay csiSet callback, unlock SUs - Issue immcfg to change saAmfSIPrefActiveAssignments Testing, Expected Results: -------------------------- Got Resource abort error string error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21) OI reports: IMM: Resource abort: Completed validation fails (Error code: 18) OI reports: SG'safSg=AmfDemo2,safApp=AmfDemo2' is not stable (1) Conditions of Submission: ------------------------- ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
