Hi Ramesh & Mahesh! Have you had time to look at this yet?
regards, Anders Widell On 11/03/2016 05:13 PM, Anders Widell wrote: > Summary: mds: Make the MdsLog implementation lock-free [#2127] > Review request for Trac Ticket(s): 2127 > Peer Reviewer(s): Mahesh, Ramesh > Pull request to: > Affected branch(es): default(5.2) > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries y > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 3ca410774e02b702bde5f1b0adf828874ad489c1 > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 03 Nov 2016 17:07:30 +0100 > > base: Remove dynamic memory allocation from the Buffer class [#2127] > > Make the use of temporary Buffer instances on the stack more efficient, > by > storing the buffer data in a character array inside the class instead of > allocating it dynamically. > > changeset d8f626a20254d5d21bdc2fe1c86e920e88d7d4ba > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 03 Nov 2016 17:07:39 +0100 > > base: Add a Buffer::Write() method taking a format string and a va_list > parameter [#2127] > > Make it possible to send a format string and a va_list to > Buffer::Write, so > that it can be used more efficiently in a printf-style function. > > changeset 9c8c71b4d740b511234625a6aff4f28bd8bb6120 > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 03 Nov 2016 17:07:47 +0100 > > base: Make the UnixSocket class thread-safe [#2127] > > Make the UnixSocket class thread-safe by protecting Open() and Close() > with > a mutex. > > changeset 72add090922c93c082e3f40543291bdb9b39c8f1 > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 03 Nov 2016 17:08:03 +0100 > > mds: Make the MdsLog implementation lock-free [#2127] > > Remove the mutex from the MdsLog class, by allocating a temporary Buffer > instance on the stack and relying on the newly implemented > thread-safety in > the UnixSocket class. > > changeset 426b4b404464d8ad966dd0cca2695e49465637ec > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 03 Nov 2016 17:08:11 +0100 > > mds: Use the va_list version of the Buffer::Write() method [#2127] > > Use the va_list version of Buffer::Write() to avoid the need for > formatting > the message into a temporary buffer. > > > Complete diffstat: > ------------------ > osaf/libs/core/cplusplus/base/buffer.h | 26 > ++++++++----------- > osaf/libs/core/cplusplus/base/log_message.cc | 106 > ---------------------------------------------------------------------------------- > osaf/libs/core/cplusplus/base/log_message.h | 182 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- > osaf/libs/core/cplusplus/base/tests/log_message_test.cc | 14 +++++----- > osaf/libs/core/cplusplus/base/unix_client_socket.cc | 28 > ++++++++------------- > osaf/libs/core/cplusplus/base/unix_client_socket.h | 2 +- > osaf/libs/core/cplusplus/base/unix_server_socket.cc | 19 > +++----------- > osaf/libs/core/cplusplus/base/unix_server_socket.h | 4 +- > osaf/libs/core/cplusplus/base/unix_socket.cc | 49 > ++++++++++++++++++++++++++++++++----- > osaf/libs/core/cplusplus/base/unix_socket.h | 22 > ++++++++++------ > osaf/libs/core/mds/include/mds_log.h | 10 +++--- > osaf/libs/core/mds/mds_log.cc | 79 > ++++++++++++++++++------------------------------------------ > 12 files changed, 298 insertions(+), 243 deletions(-) > > > Testing Commands: > ----------------- > Run regression tests, especially related to MDS logging. > > > Testing, Expected Results: > -------------------------- > Regression tests should pass. > > > Conditions of Submission: > ------------------------- > Ack from reviewer(s) > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
