ack, code review only. Minor comment below. /Thanks HansN
On 11/08/2016 05:53 AM, [email protected] wrote: > osaf/libs/agents/saf/amfa/amf_agent.cc | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > > diff --git a/osaf/libs/agents/saf/amfa/amf_agent.cc > b/osaf/libs/agents/saf/amfa/amf_agent.cc > --- a/osaf/libs/agents/saf/amfa/amf_agent.cc > +++ b/osaf/libs/agents/saf/amfa/amf_agent.cc > @@ -617,8 +617,16 @@ SaAisErrorT AmfAgent::ComponentUnregiste > rc = SA_AIS_ERR_LIBRARY; > goto done; > } > + > /* acquire cb read lock */ > m_NCS_LOCK(&cb->lock, NCS_LOCK_READ); > + /* Version is previously set in in initialize function */ > + if(ava_B4_ver_used(cb)) { [HansN] use space between if ( > + TRACE_2("Invalid AMF version, B 4.1"); > + rc = SA_AIS_ERR_VERSION; > + goto done; > + } > + > /* retrieve hdl rec */ > if ( !(hdl_rec = (AVA_HDL_REC *)ncshm_take_hdl(NCS_SERVICE_ID_AVA, hdl)) > ) { > rc = SA_AIS_ERR_BAD_HANDLE; ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
