Hi Nagu,
The question was that this code is not run after SA_AIS_ERR_NO_OP is
handled, is this correct?
:
if ((SA_AIS_OK == amf_rc) && (NCSCC_RC_SUCCESS == rc)) {
/*** clear the err params ***/
err_info = &comp->err_info;
err_info->src = static_cast<AVND_ERR_SRC>(0);
err_info->detect_time = 0;
/* Inform AMFD to generate ErrorClear() notification */
clear_error_report_alarm(comp);
}
/Thanks HansN
On 11/29/2016 09:58 AM, Nagendra Kumar wrote:
> Thanks Hans. Please specify err parms ? This is the case when there is no
> error as Oper state is enable.
>
> Thanks
> -Nagu
>> -----Original Message-----
>> From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
>> Sent: 29 November 2016 12:55
>> To: Nagendra Kumar; Praveen Malviya; minh.c...@dektech.com.au;
>> gary....@dektech.com.au
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [PATCH 1 of 1] amfnd: return SA_AIS_ERR_NO_OP for error
>> clear api [#245]
>>
>> ack, code review only. One question, shouldn't the err parms be cleared
>> afterwards, as this is not an error?
>>
>> /Regards HansN
>>
>>
>> On 11/07/2016 06:32 AM, nagendr...@oracle.com wrote:
>>> osaf/services/saf/amf/amfnd/err.cc | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>>
>>> diff --git a/osaf/services/saf/amf/amfnd/err.cc
>>> b/osaf/services/saf/amf/amfnd/err.cc
>>> --- a/osaf/services/saf/amf/amfnd/err.cc
>>> +++ b/osaf/services/saf/amf/amfnd/err.cc
>>> @@ -270,6 +270,9 @@ uint32_t avnd_evt_ava_err_clear_evh(AVND
>>> (!m_AVND_COMP_TYPE_IS_PREINSTANTIABLE(comp) &&
>> !m_AVND_COMP_TYPE_IS_PROXIED(comp)))
>>> amf_rc = SA_AIS_ERR_BAD_OPERATION;
>>>
>>> + if (m_AVND_COMP_OPER_STATE_IS_ENABLED(comp))
>>> + amf_rc = SA_AIS_ERR_NO_OP;
>>> +
>>> /* send the response back to AvA */
>>> rc = avnd_amf_resp_send(cb, AVSV_AMF_ERR_CLEAR, amf_rc, 0,
>>> &api_info->dest, &evt->mds_ctxt, comp,
>> msg_from_avnd);
>>
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
