Summary: amf: support restrictions to auto-repair
Review request for Trac Ticket(s): 2144
Peer Reviewer(s): praveen, nagu
Pull request to:
Affected branch(es): default
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This patch should be applied on top of the previous one.
changeset e49b3bcc81901987abe8a221c3a561f883b91a57
Author: Alex Jones <ajo...@genband.com>
Date: Wed, 30 Nov 2016 15:32:19 -0500
amf: support restrictions to auto-repair V2 [#2144]
This patch implements section 3.11.1.4.2 of AMF spec (Restrictions to
Auto-
Repair).
Complete diffstat:
------------------
osaf/libs/common/amf/d2nedu.c | 15 ++++-
osaf/libs/common/amf/d2nmsg.c | 12 ++++
osaf/libs/common/amf/include/amf_d2nmsg.h | 13 ++++
osaf/services/saf/amf/amfd/comp.cc | 2 +-
osaf/services/saf/amf/amfd/include/su.h | 2 +-
osaf/services/saf/amf/amfd/include/util.h | 1 +
osaf/services/saf/amf/amfd/mds.cc | 2 +-
osaf/services/saf/amf/amfd/sgproc.cc | 2 +-
osaf/services/saf/amf/amfd/su.cc | 35 +++++++++++-
osaf/services/saf/amf/amfd/util.cc | 74 ++++++++++++++++++++++++++
osaf/services/saf/amf/amfnd/clc.cc | 28 ++++++---
osaf/services/saf/amf/amfnd/err.cc | 20 +++++-
osaf/services/saf/amf/amfnd/evt.cc | 2 +
osaf/services/saf/amf/amfnd/include/avnd_evt.h | 1 +
osaf/services/saf/amf/amfnd/include/avnd_mds.h | 4 +-
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/main.cc | 1 +
osaf/services/saf/amf/amfnd/mds.cc | 6 +-
osaf/services/saf/amf/amfnd/su.cc | 46 ++++++++++++++++
osaf/services/saf/amf/amfnd/susm.cc | 10 ++-
20 files changed, 252 insertions(+), 27 deletions(-)
Testing Commands:
-----------------
1) set saAmfSUMaintenanceCampaign for an SU
2) try different failure scenarios on components in the SU (kill a component,
etc)
Testing, Expected Results:
--------------------------
1) auto-repair should never be engaged while the saAmfSUMaintenanceCampaign is
set
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
