Summary: log: fix bad file discriptor error when changing imm attributes[#2215] Review request for Trac Ticket(s): #2215 Peer Reviewer(s): Vu, Lennart, Mahesh Pull request to: Vu Affected branch(es): all branches Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 66accd7c9d76e86e51bdd6fb54735e48669c9e16 Author: Canh Van Truong <[email protected]> Date: Fri, 02 Dec 2016 12:02:20 +0700 log: fix bad file discriptor error when changing imm attributes[#2215] Issues: This is happen when changing IMM attribute in logs service. Following actions will be happen in IMM apply callback: 1. closing log file 2. Rename cfg/log file 3. create/open new cfg/log file In closing action(1), it need time to sync data from cache to disc device before closing file. The sync data takes long time and cause log service timeout. With closing action timeout, we do not know that closing file is successful or not. After closing action(1) timeout, apply callback is returned and new cfg/log file are not created. If closing action timeout but log file was closed successfully, 2 cases may be happen: a. Continue change this attribute with the same stream. Closing file action is happen again. One request is send to log file handle thread to sync data and closing file with the fd that could be closed successfull from previous closing file action. That causes bad discriptor error. b. Write log records. Because the new log file has not be created and log server still write the record to file with old fd that has be closed successfull from previous closing file action. This also causes bad file discriptor. Solution: In step 1 above, after closing log file fail, log service can contine to rename and open new file actions. Convert ER to WA and add some WA. Complete diffstat: ------------------ osaf/services/saf/logsv/lgs/lgs_imm.cc | 14 +++++++------- osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 2 +- osaf/services/saf/logsv/lgs/lgs_stream.cc | 38 ++++++++++++++++++-------------------- 3 files changed, 26 insertions(+), 28 deletions(-) Testing Commands: ----------------- Run all test cases in test suite 4, 5, 6 Testing, Expected Results: -------------------------- All test case pass Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
