Summary: amfnd: monitor immnd process using FIFO [#2158] Review request for Trac Ticket(s): #2158 Peer Reviewer(s): <<LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE>> Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Require #2204 to test. changeset 2873f21e5e4c314170c3a35696b75f3382fd824f Author: Praveen Malviya <[email protected]> Date: Tue, 13 Dec 2016 16:13:46 +0530 amfnd: monitor immnd process using FIFO [#2158] If IMMND dies before it becomes AMF component there is no entity to restart it. With ticket #2204, NID will monitor using existing FIFO each of the started process until it itself exits. This patch will also monitor IMMND using FIFO. If IMMND dies before becoming AMF component and after NID exit then with this patch AMFND will reboot the node because AMFND does not have configuration to restart IMMND. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 11 +++++++++ osaf/services/saf/amf/amfnd/comp.cc | 13 +++++++++++ osaf/services/saf/amf/amfnd/evt.cc | 4 +++ osaf/services/saf/amf/amfnd/include/avnd_cb.h | 6 +++++ osaf/services/saf/amf/amfnd/include/avnd_comp.h | 1 + osaf/services/saf/amf/amfnd/include/avnd_evt.h | 1 + osaf/services/saf/amf/amfnd/include/avnd_proc.h | 1 + osaf/services/saf/amf/amfnd/main.cc | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 8 files changed, 105 insertions(+), 4 deletions(-) Testing Commands: ----------------- case1)Kill immnd before it becomes AMF component and before NID exit. case2)Brought up two controllers and killed immnd on standby. Testing, Expected Results: -------------------------- case 1) to be tested waiting for #2204 to get pushed. case 2)Since IMM becomes AMF component, AMFND will not reboot.As soon as IMMND restarts, AMFND will continue monitoring. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
