Summary: amfd: increase max job queue size at standby [#2228]
Review request for Trac Ticket(s): 2228
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): all
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset eb123431749941e953430ddf13452a01d347c21c
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 04 Jan 2017 14:30:10 +1100
amfd: increase max job queue size at standby [#2228]
After a cold sync, the standby job queue size can exceed the current
limit
of 200. This results in the emptying of the entire queue at standby.
Potentially, some IMM updates are not done, as all jobs will be deleted
during a failover if the size is exceeded. This is especially important
for
updates that the old 'active' could not perform in time during the
failover.
This patch attempts to reduce the occurrence of this by increasing the
max
size, and only trimming the queue to half the maximum size. The updates
that
must be done are likely to be located towards the end of the queue, and
these are kept.
Complete diffstat:
------------------
src/amf/amfd/imm.cc | 28 +++++++++++++++++++++++-----
src/amf/amfd/imm.h | 2 ++
2 files changed, 25 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
Execute SC failover
Testing, Expected Results:
--------------------------
Before this patch, during a SC failover, it can be seen that the queue size
with only OpenSAF running
can exceed 200. Thus some IMM updates are possibly lost.
After the patch, this should not be normally seen in the logs:
"WA: Reducing job queue of size ...."
Conditions of Submission:
-------------------------
Ack from any reviewer, or in 14 days.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
