Summary: amfd: remove quiesced susis during lock operation, without sidep
[#316]
Review request for Trac Ticket(s): #316
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 2c3c78ce123e0145003a5b09ce2253c4c7e16fde
Author: Praveen Malviya <praveen.malv...@oracle.com>
Date: Thu, 05 Jan 2017 11:48:04 +0530
amfd: remove quiesced susis during lock operation, without sidep [#316]
During lock/shutdown operation on SU, Node and NG, some times AMFD is
not
removing quiesced assignments. The ticket reports this problem when
sidep is
enabled and disabled.
This issue comes in a specific situation when AMFD is unable to
switchover
all the assignments of locked SU and AMFD removes the locked SU from the
oper_list before the removal of all assignments. Also in realign state
the
case to send removal of assignments to quiesced SU when new active SU
is in
oper_list is not handled. Assignment distribution is like this : SI1
and SI2
active in SU1 and SI3 standby in SU1. SI1 and SI2 standby in SU3 and SI3
active in SU2. During SU1 lock, AMFD sends quiesced HA state for SI1
and SI2
to SU1 and add it in oper_list and marks SG in SU_OPER. After SI1 gets
quiesced, AMFD sends active for it to SU2. Before SI1 becomes active in
SU2,
SI2 becomes quiesced. SU2 cannot take further active assignment because
of
configuration limitation. AMFD sends removal of SI2 in both SU1 and SU2.
AMFD gets removal response from SU1 for SI2 and it removes SU1 from
oper_list and marks SG in REALIGN state. When SI1 becomes active in SU2,
AMFD does not remove quiesced assignment from SU1 as this case is not
handled.
Patch fixes the problem to send removal of assignment when SIs becomes
active in other SUs and when SI dep is not configured.
Note: Patch does not cover SI dep issue.
Complete diffstat:
------------------
src/amf/amfd/sg_nway_fsm.cc | 192
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------
src/amf/amfd/su.cc | 11 ++++
src/amf/amfd/su.h | 1 +
3 files changed, 151 insertions(+), 53 deletions(-)
Testing Commands:
-----------------
Problem is reproducible with the configuration given in the commit log and also
attached in the
ticket. Tested following cases (In all these cases problem is reproducible) :
1)SU lock and delay active in Su2 (one comp conf).
2)SU lock and delay active in Su2 (two comps conf).
3)NG lock containing only one node which hosts SU1 (two comps conf).
4)sufailover when SI1 is becoming active in SU2.
All these four cases were reported in commnet part of the ticket.
Testing, Expected Results:
--------------------------
All the above four cases passed.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
