Summary: cpd: syncup active standby mbcsv dtat for non-colcated ckpt above 3
replicas[#2253]
Review request for Trac Ticket(s): #2253
Peer Reviewer(s): Hoang
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): defualt to 5.1
Development branch: defult
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 5b5e63b7861293488e5d718856c3b34eaa7bba59
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Fri, 06 Jan 2017 17:41:53 +0530
cpd: syncup active standby mbcsv dtat for non-colcated ckpt above 3
replicas[#2253]
Issue : According to Ckpt non-collocated ckpt
implementation the cluster can have max 3 replicas
and minimum of 2 replicas,if the non-collocated ckpt is opened on
controller
initially , by default cpsv service will create 2
replicas each one on controllers , else the non-
collocated ckpt is opened on payload initially,by default cpsv service
will
create 3 replicas one on the payload and other
each one on controllers,so any further opens form any other payload is
not
required to create replicas locally.All other node ckpt application will
access the data form the default created active
replica.
In current code ha bug in active standby MBCSV
checkpoint of CPD_CKPT_REF_INFO data is mismatching
while creating replica node for non-collocated of a payload
Fix : This patch address the issue by matching
CPD_CKPT_REF_INFO data by not crating
cpd_ckpt_reploc_node cpd_ckpt_ref_info , for the any further opens
form any other payload opened the ckpt above max 3 replicas.
Complete diffstat:
------------------
src/ckpt/ckptd/cpd_sbevt.c | 30 +++++++++++++++++++++---------
1 files changed, 21 insertions(+), 9 deletions(-)
Testing Commands:
-----------------
Steps to reproduce :
1) bring-up 4 nodes cluster ( 2 controleers 2 paylods )
-SC-1 Active
- SC-2 -Standby
- PL3
- PL4
2) create/open same non-collocated cktp on payloads in following sequence
and don't close the ckpt
- PL3
-PL4
3) bring-down payloads in following sequence
- PL4
-PL3
4) now bring down controller in following sequence
- SC-1 -Active(fist )
- SC-2 -Standby ( next )
you will observed ER Deleting run time object safReplica in osafckptd traces
Testing, Expected Results:
--------------------------
No Deleting run time object safReplica Error
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
